@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Ponder Exception, spacing
Summary: Evidently I only tested adding a question, not an answer. Properly set the getter. Also, fixed some header spacing.
Test Plan: Add a question, add an answer. See everything work, proper spacing.
Reviewers: epriestley, avivey
Reviewed By: avivey
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15341
+15
-5
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
92
92
'rsrc/css/application/policy/policy-edit.css' => '815c66f7',
93
93
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
94
94
'rsrc/css/application/policy/policy.css' => '957ea14c',
95
-
'rsrc/css/application/ponder/ponder-view.css' => 'fdd4629b',
95
+
'rsrc/css/application/ponder/ponder-view.css' => '212495e0',
96
96
'rsrc/css/application/project/project-card-view.css' => '9418c97d',
97
97
'rsrc/css/application/project/project-view.css' => '298b7c5b',
98
98
'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733',
···
855
855
'policy-css' => '957ea14c',
856
856
'policy-edit-css' => '815c66f7',
857
857
'policy-transaction-detail-css' => '82100a43',
858
-
'ponder-view-css' => 'fdd4629b',
858
+
'ponder-view-css' => '212495e0',
859
859
'project-card-view-css' => '9418c97d',
860
860
'project-view-css' => '298b7c5b',
861
861
'releeph-core' => '9b3c5733',
+6
-1
src/applications/ponder/controller/PonderQuestionViewController.php
+6
-1
src/applications/ponder/controller/PonderQuestionViewController.php
···
322
322
323
323
$header = id(new PHUIHeaderView())
324
324
->setHeader('Answers');
325
-
return array($header, $view);
325
+
326
+
327
+
return id(new PHUIBoxView())
328
+
->addClass('ponder-answer-section')
329
+
->appendChild($header)
330
+
->appendChild($view);
326
331
}
327
332
328
333
return null;
+2
-1
src/applications/ponder/storage/PonderAnswer.php
+2
-1
src/applications/ponder/storage/PonderAnswer.php
···
17
17
protected $content;
18
18
protected $mailKey;
19
19
protected $status;
20
+
protected $voteCount;
20
21
21
22
private $question = self::ATTACHABLE;
22
23
private $comments;
···
34
35
->setContent('')
35
36
->attachQuestion($question)
36
37
->setAuthorPHID($actor->getPHID())
37
-
->setVoteCount('0')
38
+
->setVoteCount(0)
38
39
->setStatus(PonderAnswerStatus::ANSWER_STATUS_VISIBLE);
39
40
40
41
}
+5
-1
webroot/rsrc/css/application/ponder/ponder-view.css
+5
-1
webroot/rsrc/css/application/ponder/ponder-view.css
···
169
169
}
170
170
171
171
.ponder-answer-view .ponder-footer-view {
172
-
margin-top: 24px;
172
+
margin-top: 16px;
173
173
border-top: 1px solid rgba({$alphagrey}, .15);
174
174
border-bottom: none;
175
175
}
···
184
184
padding: 8px 0;
185
185
margin-right: 8px;
186
186
display: inline-block;
187
+
}
188
+
189
+
.ponder-answer-section {
190
+
margin-top: 32px;
187
191
}
188
192
189
193
.ponder-add-answer-header {