@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix button for "All Problem Commits" on Owners packages
Summary:
Ref T9482. This button goes to the wrong place and this table conditionally hides itself so I missed it.
Instead:
- Always show the table, with an empty string if there are no relevant commits.
- Link to a working UI.
Test Plan: Saw table. Clicked button.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9482
Differential Revision: https://secure.phabricator.com/D14189
+15
-14
+15
-14
src/applications/owners/controller/PhabricatorOwnersDetailController.php
+15
-14
src/applications/owners/controller/PhabricatorOwnersDetailController.php
···
76
76
'auditorPHIDs' => $package->getPHID(),
77
77
));
78
78
79
+
$status_concern = DiffusionCommitQuery::AUDIT_STATUS_CONCERN;
80
+
79
81
$attention_commits = id(new DiffusionCommitQuery())
80
82
->setViewer($request->getUser())
81
83
->withAuditorPHIDs(array($package->getPHID()))
82
-
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_CONCERN)
84
+
->withAuditStatus($status_concern)
83
85
->needCommitData(true)
84
86
->setLimit(10)
85
87
->execute();
86
-
if ($attention_commits) {
87
-
$view = id(new PhabricatorAuditListView())
88
-
->setUser($viewer)
89
-
->setCommits($attention_commits);
88
+
$view = id(new PhabricatorAuditListView())
89
+
->setUser($viewer)
90
+
->setNoDataString(pht('This package has no open problem commits.'))
91
+
->setCommits($attention_commits);
90
92
91
-
$commit_views[] = array(
92
-
'view' => $view,
93
-
'header' => pht('Commits in this Package that Need Attention'),
94
-
'button' => id(new PHUIButtonView())
95
-
->setTag('a')
96
-
->setHref($commit_uri->alter('status', 'open'))
97
-
->setText(pht('View All Problem Commits')),
98
-
);
99
-
}
93
+
$commit_views[] = array(
94
+
'view' => $view,
95
+
'header' => pht('Commits in this Package that Need Attention'),
96
+
'button' => id(new PHUIButtonView())
97
+
->setTag('a')
98
+
->setHref($commit_uri->alter('status', $status_concern))
99
+
->setText(pht('View All Problem Commits')),
100
+
);
100
101
101
102
$all_commits = id(new DiffusionCommitQuery())
102
103
->setViewer($request->getUser())