@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix "Welcome Mail" check for a message when no message exists
Summary: Fixes T13239. See that task for discussion.
Test Plan: Tried to send welcome mail with no "Welcome" message.
Maniphest Tasks: T13239
Differential Revision: https://secure.phabricator.com/D20001
+1
-1
+1
-1
src/applications/people/controller/PhabricatorPeopleWelcomeController.php
+1
-1
src/applications/people/controller/PhabricatorPeopleWelcomeController.php
···
51
51
$default_message = PhabricatorAuthMessage::loadMessage(
52
52
$admin,
53
53
PhabricatorAuthWelcomeMailMessageType::MESSAGEKEY);
54
-
if (strlen($default_message->getMessageText())) {
54
+
if ($default_message && strlen($default_message->getMessageText())) {
55
55
$message_instructions = pht(
56
56
'The email will identify you as the sender. You may optionally '.
57
57
'replace the [[ %s | default custom mail body ]] with different text '.