@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't try to import proxy columns
Summary:
Fixes T10346. You finally wrung a clue out of the reporter and I think I figured this out.
Here's the bug:
- Create a project with a workboard and subprojects/milestones.
- Create a new project, import columns from the first project.
- We incorrectly import empty columns for the subprojects/milestons.
Instead, skip proxy columns during import.
Also, allow "hide column" to continue on missing fields, so columns with no name can be hidden.
Test Plan:
- Did the stuff above.
- Workboard no longer populated with a bunch of "Unnamed Column" columns.
- Hid several "Unnamed Column" columns.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10346
Differential Revision: https://secure.phabricator.com/D15265
+5
+4
src/applications/project/controller/PhabricatorProjectBoardImportController.php
+4
src/applications/project/controller/PhabricatorProjectBoardImportController.php
···
50
50
if ($import_column->isHidden()) {
51
51
continue;
52
52
}
53
+
if ($import_column->getProxy()) {
54
+
continue;
55
+
}
56
+
53
57
$new_column = PhabricatorProjectColumn::initializeNewColumn($viewer)
54
58
->setSequence($import_column->getSequence())
55
59
->setProjectPHID($project->getPHID())
+1
src/applications/project/controller/PhabricatorProjectColumnHideController.php
+1
src/applications/project/controller/PhabricatorProjectColumnHideController.php