@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make PeopleQuery throw, not select everything, when handed empty array
Summary: Make `->withPHIDs(array())` throw on this query instead of selecting everything.
Test Plan: Poked around.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D9210
+5
-5
+5
-5
src/applications/people/query/PhabricatorPeopleQuery.php
+5
-5
src/applications/people/query/PhabricatorPeopleQuery.php
···
200
200
private function buildWhereClause($conn_r) {
201
201
$where = array();
202
202
203
-
if ($this->usernames) {
203
+
if ($this->usernames !== null) {
204
204
$where[] = qsprintf(
205
205
$conn_r,
206
206
'user.userName IN (%Ls)',
207
207
$this->usernames);
208
208
}
209
209
210
-
if ($this->emails) {
210
+
if ($this->emails !== null) {
211
211
$where[] = qsprintf(
212
212
$conn_r,
213
213
'email.address IN (%Ls)',
214
214
$this->emails);
215
215
}
216
216
217
-
if ($this->realnames) {
217
+
if ($this->realnames !== null) {
218
218
$where[] = qsprintf(
219
219
$conn_r,
220
220
'user.realName IN (%Ls)',
221
221
$this->realnames);
222
222
}
223
223
224
-
if ($this->phids) {
224
+
if ($this->phids !== null) {
225
225
$where[] = qsprintf(
226
226
$conn_r,
227
227
'user.phid IN (%Ls)',
228
228
$this->phids);
229
229
}
230
230
231
-
if ($this->ids) {
231
+
if ($this->ids !== null) {
232
232
$where[] = qsprintf(
233
233
$conn_r,
234
234
'user.id IN (%Ld)',