+2

src/__phutil_library_map__.php

reviewed

··· 223 223 'AuditQueryConduitAPIMethod' => 'applications/audit/conduit/AuditQueryConduitAPIMethod.php', 224 224 'AuthManageProvidersCapability' => 'applications/auth/capability/AuthManageProvidersCapability.php', 225 225 'BulkParameterType' => 'applications/transactions/bulk/type/BulkParameterType.php', 226 226 + 'BulkSelectParameterType' => 'applications/transactions/bulk/type/BulkSelectParameterType.php', 226 227 'BulkStringParameterType' => 'applications/transactions/bulk/type/BulkStringParameterType.php', 227 228 'CalendarTimeUtil' => 'applications/calendar/util/CalendarTimeUtil.php', 228 229 'CalendarTimeUtilTestCase' => 'applications/calendar/__tests__/CalendarTimeUtilTestCase.php', ··· 5244 5245 'AuditQueryConduitAPIMethod' => 'AuditConduitAPIMethod', 5245 5246 'AuthManageProvidersCapability' => 'PhabricatorPolicyCapability', 5246 5247 'BulkParameterType' => 'Phobject', 5248 5248 + 'BulkSelectParameterType' => 'BulkParameterType', 5247 5249 'BulkStringParameterType' => 'BulkParameterType', 5248 5250 'CalendarTimeUtil' => 'Phobject', 5249 5251 'CalendarTimeUtilTestCase' => 'PhabricatorTestCase',

+2

src/applications/maniphest/editor/ManiphestEditEngine.php

reviewed

··· 201 201 id(new PhabricatorSelectEditField()) 202 202 ->setKey('status') 203 203 ->setLabel(pht('Status')) 204 204 + ->setBulkEditLabel(pht('Set status to')) 204 205 ->setDescription(pht('Status of the task.')) 205 206 ->setConduitDescription(pht('Change the task status.')) 206 207 ->setConduitTypeDescription(pht('New task status constant.')) ··· 213 214 id(new PhabricatorSelectEditField()) 214 215 ->setKey('priority') 215 216 ->setLabel(pht('Priority')) 217 217 + ->setBulkEditLabel(pht('Set priority to')) 216 218 ->setDescription(pht('Priority of the task.')) 217 219 ->setConduitDescription(pht('Change the priority of the task.')) 218 220 ->setConduitTypeDescription(pht('New task priority constant.'))

+10

src/applications/transactions/bulk/type/BulkParameterType.php

reviewed

··· 3 3 abstract class BulkParameterType extends Phobject { 4 4 5 5 private $viewer; 6 6 + private $field; 6 7 7 8 final public function setViewer(PhabricatorUser $viewer) { 8 9 $this->viewer = $viewer; ··· 11 12 12 13 final public function getViewer() { 13 14 return $this->viewer; 15 15 + } 16 16 + 17 17 + final public function setField(PhabricatorEditField $field) { 18 18 + $this->field = $field; 19 19 + return $this; 20 20 + } 21 21 + 22 22 + final public function getField() { 23 23 + return $this->field; 14 24 } 15 25 16 26 abstract public function getPHUIXControlType();

+22

src/applications/transactions/bulk/type/BulkSelectParameterType.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + final class BulkSelectParameterType 4 4 + extends BulkParameterType { 5 5 + 6 6 + public function getOptions() { 7 7 + return $this->getField()->getOptions(); 8 8 + } 9 9 + 10 10 + public function getPHUIXControlType() { 11 11 + return 'select'; 12 12 + } 13 13 + 14 14 + public function getPHUIXControlSpecification() { 15 15 + return array( 16 16 + 'options' => $this->getOptions(), 17 17 + 'order' => array_keys($this->getOptions()), 18 18 + 'value' => null, 19 19 + ); 20 20 + } 21 21 + 22 22 + }

+3 -1

src/applications/transactions/editfield/PhabricatorEditField.php

reviewed

··· 643 643 return null; 644 644 } 645 645 646 646 - $type->setViewer($this->getViewer()); 646 646 + $type 647 647 + ->setField($this) 648 648 + ->setViewer($this->getViewer()); 647 649 648 650 return $type; 649 651 }

+4

src/applications/transactions/editfield/PhabricatorSelectEditField.php

reviewed

··· 54 54 return new ConduitStringParameterType(); 55 55 } 56 56 57 57 + protected function newBulkParameterType() { 58 58 + return new BulkSelectParameterType(); 59 59 + } 60 60 + 57 61 private function getCanonicalValue($value) { 58 62 $options = $this->getOptions(); 59 63 if (!isset($options[$value])) {