@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make passing an object to newCurtain optional
Summary: We seem to already support this, just takes it fully there. We don't need to see things like "Flag", etc, on certain subpages of projects/people/etc.
Test Plan: Review Members, Subproject pages, no longer see "Flag for Later" which only is for the Project itself. Check manage, still there.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17897
+8
-6
+6
-4
src/applications/base/controller/PhabricatorController.php
+6
-4
src/applications/base/controller/PhabricatorController.php
···
471
471
->setViewer($this->getViewer());
472
472
}
473
473
474
-
public function newCurtainView($object) {
474
+
public function newCurtainView($object = null) {
475
475
$viewer = $this->getViewer();
476
476
477
477
$action_id = celerity_generate_unique_node_id();
···
491
491
->setViewer($viewer)
492
492
->setActionList($action_list);
493
493
494
-
$panels = PHUICurtainExtension::buildExtensionPanels($viewer, $object);
495
-
foreach ($panels as $panel) {
496
-
$curtain->addPanel($panel);
494
+
if ($object) {
495
+
$panels = PHUICurtainExtension::buildExtensionPanels($viewer, $object);
496
+
foreach ($panels as $panel) {
497
+
$curtain->addPanel($panel);
498
+
}
497
499
}
498
500
499
501
return $curtain;
+1
-1
src/applications/project/controller/PhabricatorProjectMembersViewController.php
+1
-1
src/applications/project/controller/PhabricatorProjectMembersViewController.php
+1
-1
src/applications/project/controller/PhabricatorProjectSubprojectsController.php
+1
-1
src/applications/project/controller/PhabricatorProjectSubprojectsController.php
···
203
203
$allows_milestones = $project->supportsMilestones();
204
204
$allows_subprojects = $project->supportsSubprojects();
205
205
206
-
$curtain = $this->newCurtainView($project);
206
+
$curtain = $this->newCurtainView();
207
207
208
208
if ($allows_milestones && $milestones) {
209
209
$milestone_text = pht('Create Next Milestone');