@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove vestigal "tags" stuff from Herald

Summary: Ref T8726. No clue what this was.

Test Plan: Grepped for usage, found none.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: eadler, epriestley

Maniphest Tasks: T8726

Differential Revision: https://secure.phabricator.com/D13498

-6
-6
src/applications/herald/adapter/HeraldAdapter.php
··· 9 9 const FIELD_REVIEWER = 'reviewer'; 10 10 const FIELD_REVIEWERS = 'reviewers'; 11 11 const FIELD_COMMITTER = 'committer'; 12 - const FIELD_TAGS = 'tags'; 13 12 const FIELD_DIFF_FILE = 'diff-file'; 14 13 const FIELD_DIFF_CONTENT = 'diff-content'; 15 14 const FIELD_DIFF_ADDED_CONTENT = 'diff-added-content'; ··· 79 78 const VALUE_NONE = 'none'; 80 79 const VALUE_EMAIL = 'email'; 81 80 const VALUE_USER = 'user'; 82 - const VALUE_TAG = 'tag'; 83 81 const VALUE_RULE = 'rule'; 84 82 const VALUE_REPOSITORY = 'repository'; 85 83 const VALUE_OWNERS_PACKAGE = 'package'; ··· 371 369 self::FIELD_COMMITTER => pht('Committer'), 372 370 self::FIELD_REVIEWER => pht('Reviewer'), 373 371 self::FIELD_REVIEWERS => pht('Reviewers'), 374 - self::FIELD_TAGS => pht('Tags'), 375 372 self::FIELD_DIFF_FILE => pht('Any changed filename'), 376 373 self::FIELD_DIFF_CONTENT => pht('Any changed file content'), 377 374 self::FIELD_DIFF_ADDED_CONTENT => pht('Any added file content'), ··· 471 468 self::CONDITION_EXISTS, 472 469 self::CONDITION_NOT_EXISTS, 473 470 ); 474 - case self::FIELD_TAGS: 475 471 case self::FIELD_REVIEWERS: 476 472 case self::FIELD_AUTHOR_PROJECTS: 477 473 case self::FIELD_AFFECTED_PACKAGE: ··· 940 936 switch ($field) { 941 937 case self::FIELD_REPOSITORY: 942 938 return self::VALUE_REPOSITORY; 943 - case self::FIELD_TAGS: 944 - return self::VALUE_TAG; 945 939 case self::FIELD_AFFECTED_PACKAGE: 946 940 return self::VALUE_OWNERS_PACKAGE; 947 941 case self::FIELD_AUTHOR_PROJECTS: