@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make "Audit Requested" put commits into the "Needs Audit" state
Summary: Fixes T7504. I think that task legitimately describes a bug and that the current behavior is counterintuitive.
Test Plan: Manually added an auditor to a commit with none; saw it become "Audit Required" as an overall state.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T7504
Differential Revision: https://secure.phabricator.com/D17185
+1
+1
src/applications/repository/storage/PhabricatorRepositoryCommit.php
+1
src/applications/repository/storage/PhabricatorRepositoryCommit.php
···
256
256
foreach ($requests as $request) {
257
257
switch ($request->getAuditStatus()) {
258
258
case PhabricatorAuditStatusConstants::AUDIT_REQUIRED:
259
+
case PhabricatorAuditStatusConstants::AUDIT_REQUESTED:
259
260
$any_need = true;
260
261
break;
261
262
case PhabricatorAuditStatusConstants::ACCEPTED: