@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix dashboard list if there are no results
Summary:
We'll fire a bad query if there are no dashboards in the result list, see:
http://pastie.org/private/j0f8tzbdahwragxjsk8qxq
Test Plan: Viewed result list with no dashboards.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D10207
+12
-7
+12
-7
src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
+12
-7
src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
···
55
55
56
56
$dashboards = mpull($dashboards, null, 'getPHID');
57
57
$viewer = $this->requireViewer();
58
-
$installs = id(new PhabricatorDashboardInstall())
59
-
->loadAllWhere(
60
-
'objectPHID IN (%Ls) AND dashboardPHID IN (%Ls)',
61
-
array(PhabricatorHomeApplication::DASHBOARD_DEFAULT,
62
-
$viewer->getPHID()),
63
-
array_keys($dashboards));
64
-
$installs = mpull($installs, null, 'getDashboardPHID');
58
+
59
+
if ($dashboards) {
60
+
$installs = id(new PhabricatorDashboardInstall())
61
+
->loadAllWhere(
62
+
'objectPHID IN (%Ls) AND dashboardPHID IN (%Ls)',
63
+
array(PhabricatorHomeApplication::DASHBOARD_DEFAULT,
64
+
$viewer->getPHID()),
65
+
array_keys($dashboards));
66
+
$installs = mpull($installs, null, 'getDashboardPHID');
67
+
} else {
68
+
$installs = array();
69
+
}
65
70
66
71
$list = new PHUIObjectItemListView();
67
72
$list->setUser($viewer);