@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Check for empty output from git ls-tree
Summary: Fixes T10155
Test Plan: View an empty repository in diffusion, check for the exception.
See T10155 for steps to reproduce
Reviewers: epriestley
Subscribers:
+5
-1
+5
-1
src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
+5
-1
src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
···
105
105
106
106
$count = 0;
107
107
$results = array();
108
-
foreach (explode("\0", rtrim($stdout)) as $line) {
108
+
$lines = empty($stdout)
109
+
? array()
110
+
: explode("\0", rtrim($stdout));
111
+
112
+
foreach ($lines as $line) {
109
113
// NOTE: Limit to 5 components so we parse filenames with spaces in them
110
114
// correctly.
111
115
// NOTE: The output uses a mixture of tabs and one-or-more spaces to