@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Update "phabricator/" for "topological" API changes

Summary: Ref T13325.

Test Plan:
- Grepped for `topograph`.
- Viewed a task graph since that's easy, looked fine.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13325

Differential Revision: https://secure.phabricator.com/D20599

+4 -5
+1 -2
src/applications/harbormaster/engine/HarbormasterBuildGraph.php
··· 25 25 $graph = id(new HarbormasterBuildGraph($steps_by_phid)) 26 26 ->addNodes($step_phids); 27 27 28 - $raw_results = 29 - $graph->getBestEffortTopographicallySortedNodes(); 28 + $raw_results = $graph->getNodesInRoughTopologicalOrder(); 30 29 31 30 $results = array(); 32 31 foreach ($raw_results as $node) {
+2 -2
src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
··· 398 398 } 399 399 } 400 400 401 - // Now, sort them topographically. 401 + // Now, sort them topologically. 402 402 $commits = $this->reduceGraph($graph); 403 403 404 404 $refs = array(); ··· 437 437 $graph = new PhutilDirectedScalarGraph(); 438 438 $graph->addNodes($edges); 439 439 440 - $commits = $graph->getTopographicallySortedNodes(); 440 + $commits = $graph->getNodesInTopologicalOrder(); 441 441 442 442 // NOTE: We want the most ancestral nodes first, so we need to reverse the 443 443 // list we get out of AbstractDirectedGraph.
+1 -1
src/infrastructure/graph/PhabricatorObjectGraph.php
··· 189 189 190 190 $order = id(new PhutilDirectedScalarGraph()) 191 191 ->addNodes($ancestry) 192 - ->getTopographicallySortedNodes(); 192 + ->getNodesInTopologicalOrder(); 193 193 194 194 $ancestry = array_select_keys($ancestry, $order); 195 195