recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a content join condition in Phriction

After the cursor changes, we may fatal on pages with a large number of children
because "c.title" is not a selected column. We currently join the "content"
table if "updated" is part of the order vector, but not if "title" is part of
the order vector. This isn't right: "updated" is on the primary table, and only
"content" is on the joined table.

epriestley c16a8c7a b90e02be

+5 -1
+5 -1
src/applications/phriction/query/PhrictionDocumentQuery.php
··· 193 193 } 194 194 195 195 private function shouldJoinContentTable() { 196 - return $this->getOrderVector()->containsKey('updated'); 196 + if ($this->getOrderVector()->containsKey('title')) { 197 + return true; 198 + } 199 + 200 + return false; 197 201 } 198 202 199 203 protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {