@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make "A" hide or show all inline comments
Summary: Ref T12733. See PHI17.
Test Plan: Pressed "A", then pressed "A".
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12733
Differential Revision: https://secure.phabricator.com/D18274
+27
-7
+7
-7
resources/celerity/map.php
+7
-7
resources/celerity/map.php
···
13
13
'core.pkg.js' => '5d80e0db',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '45951e9e',
16
-
'differential.pkg.js' => '414ada25',
16
+
'differential.pkg.js' => 'b71b8c5d',
17
17
'diffusion.pkg.css' => 'a2d17c7d',
18
18
'diffusion.pkg.js' => '6134c5a1',
19
19
'favicon.ico' => '30672e08',
···
398
398
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
399
399
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
400
400
'rsrc/js/application/diff/DiffChangeset.js' => '99abf4cd',
401
-
'rsrc/js/application/diff/DiffChangesetList.js' => 'cb1570cb',
401
+
'rsrc/js/application/diff/DiffChangesetList.js' => '8f1cd52c',
402
402
'rsrc/js/application/diff/DiffInline.js' => 'e83d28f3',
403
403
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
404
404
'rsrc/js/application/differential/behavior-comment-preview.js' => '51c5ad07',
···
778
778
'phabricator-darkmessage' => 'c48cccdd',
779
779
'phabricator-dashboard-css' => 'fe5b1869',
780
780
'phabricator-diff-changeset' => '99abf4cd',
781
-
'phabricator-diff-changeset-list' => 'cb1570cb',
781
+
'phabricator-diff-changeset-list' => '8f1cd52c',
782
782
'phabricator-diff-inline' => 'e83d28f3',
783
783
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
784
784
'phabricator-draggable-list' => 'bea6e7f4',
···
1567
1567
'8e1baf68' => array(
1568
1568
'phui-button-css',
1569
1569
),
1570
+
'8f1cd52c' => array(
1571
+
'javelin-install',
1572
+
'phuix-button-view',
1573
+
),
1570
1574
'8ff5e24c' => array(
1571
1575
'javelin-behavior',
1572
1576
'javelin-stratcom',
···
1949
1953
),
1950
1954
'cae95e89' => array(
1951
1955
'syntax-default-css',
1952
-
),
1953
-
'cb1570cb' => array(
1954
-
'javelin-install',
1955
-
'phuix-button-view',
1956
1956
),
1957
1957
'ccf1cbf8' => array(
1958
1958
'javelin-install',
+3
src/applications/differential/view/DifferentialChangesetListView.php
+3
src/applications/differential/view/DifferentialChangesetListView.php
+17
webroot/rsrc/js/application/diff/DiffChangesetList.js
+17
webroot/rsrc/js/application/diff/DiffChangesetList.js
···
190
190
191
191
label = pht('Collapse or expand inline comment.');
192
192
this._installKey('q', label, this._onkeycollapse);
193
+
194
+
label = pht('Hide or show all inline comments.');
195
+
this._installKey('A', label, this._onkeyhideall);
196
+
193
197
},
194
198
195
199
isAsleep: function() {
···
446
450
447
451
var pht = this.getTranslations();
448
452
this._warnUser(pht('You must select a comment to hide.'));
453
+
},
454
+
455
+
_onkeyhideall: function() {
456
+
var inlines = this._getInlinesByType();
457
+
if (inlines.visible.length) {
458
+
this._toggleInlines('all');
459
+
} else {
460
+
this._toggleInlines('show');
461
+
}
449
462
},
450
463
451
464
_warnUser: function(message) {
···
1701
1714
this._dropdownMenu.close();
1702
1715
e.prevent();
1703
1716
1717
+
this._toggleInlines(type);
1718
+
},
1719
+
1720
+
_toggleInlines: function(type) {
1704
1721
var inlines = this._getInlinesByType();
1705
1722
1706
1723
// Clear the selection state since we end up in a weird place if the