@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove redundant translations

Summary:
- Remove some redundant copies of translations after D4985.
- Make some %d more grammatical, "run this command" reads better than "run this 1 command". In context, these numbers are always very small, so counting them even in the >1 variants aren't useful.
- Fix subscriber(s).

Test Plan: Looked at an unsubscribe story, saw translation.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4989

+14 -30
+1 -1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
··· 248 248 $this->renderHandleList($add)); 249 249 } else { 250 250 return pht( 251 - '%s removed %d subscribers: %s.', 251 + '%s removed %d subscriber(s): %s.', 252 252 $this->renderHandleLink($author_phid), 253 253 count($rem), 254 254 $this->renderHandleList($rem));
+13 -29
src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php
··· 187 187 '%s added a subscriber: %3$s.', 188 188 '%s added subscribers: %3$s.', 189 189 ), 190 - array( 191 - '%s added a subscriber: %3$s.', 192 - '%s added subscribers: %3$s.', 193 - ), 194 190 ), 195 191 196 192 '%s removed %d subscriber(s): %s.' => array( ··· 198 194 '%s removed a subscriber: %3$s.', 199 195 '%s removed subscribers: %3$s.', 200 196 ), 201 - array( 202 - '%s removed a subscriber: %3$s.', 203 - '%s removed subscribers: %3$s.', 204 - ), 205 197 ), 206 198 207 199 '%s added %d participant(s): %s.' => array( ··· 209 201 '%s added a participant: %3$s.', 210 202 '%s added participants: %3$s.', 211 203 ), 212 - array( 213 - '%s added a participant: %3$s.', 214 - '%s added participants: %3$s.', 215 - ), 216 204 ), 217 205 218 206 '%s removed %d participant(s): %s.' => array( 219 - array( 220 - '%s removed a participant: %3$s.', 221 - '%s removed participants: %3$s.', 222 - ), 223 207 array( 224 208 '%s removed a participant: %3$s.', 225 209 '%s removed participants: %3$s.', ··· 242 226 ), 243 227 244 228 'Install these %d PHP extension(s):' => array( 245 - 'Install this %d PHP extension:', 246 - 'Install these %d PHP extensions:', 229 + 'Install this PHP extension:', 230 + 'Install these PHP extensions:', 247 231 ), 248 232 249 233 'The current Phabricator configuration has these %d value(s):' => array( 250 - 'The current Phabricator configuration has this %d value:', 251 - 'The current Phabricator configuration has these %d values:', 234 + 'The current Phabricator configuration has this value:', 235 + 'The current Phabricator configuration has these values:', 252 236 ), 253 237 254 238 'To update these %d value(s), run these command(s) from the command line:' 255 239 => array( 256 - 'To update this %d value, run this command from the command line:', 257 - 'To update these %d values, run these commands from the command line:', 240 + 'To update this value, run this command from the command line:', 241 + 'To update these values, run these commands from the command line:', 258 242 ), 259 243 260 244 'You can update these %d value(s) here:' => array( 261 - 'You can update this %d value here:', 262 - 'You can update these %d values here:', 245 + 'You can update this value here:', 246 + 'You can update these values here:', 263 247 ), 264 248 265 249 'The current PHP configuration has these %d value(s):' => array( 266 - 'The current PHP configuration has this %d value:', 267 - 'The current PHP configuration has these %d values:', 250 + 'The current PHP configuration has this value:', 251 + 'The current PHP configuration has these values:', 268 252 ), 269 253 270 254 'To update these %d value(s), edit your PHP configuration file.' => array( ··· 274 258 275 259 'To update these %d value(s), edit your PHP configuration file, located '. 276 260 'here:' => array( 277 - 'To update this %d value, edit your PHP configuration file, located '. 261 + 'To update this value, edit your PHP configuration file, located '. 278 262 'here:', 279 - 'To update these %d values, edit your PHP configuration file, located '. 263 + 'To update these values, edit your PHP configuration file, located '. 280 264 'here:', 281 265 ), 282 266 ··· 286 270 ), 287 271 288 272 'You have %d unresolved setup issue(s)...' => array( 289 - 'You have %d unresolved setup issue...', 273 + 'You have an unresolved setup issue...', 290 274 'You have %d unresolved setup issues...', 291 275 ), 292 276