@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't try to center dialogs horizontally
Summary:
Fixes T10302. I think we had fixed-width dialog containers in the past (?) but they all handle their own centering now.
This was causing them to be slightly off-center as a result, and creating the 7px issue in T10302.
Test Plan:
- Viewed a wide dialog (task edit).
- Viewed a narrow dialog (notification dismissal confirmation).
- Viewed dialogs on wide/narrow screens.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10302
Differential Revision: https://secure.phabricator.com/D15529
+15
-15
+14
-14
resources/celerity/map.php
+14
-14
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => '9acdee84',
11
-
'core.pkg.js' => '7d8faf57',
11
+
'core.pkg.js' => 'e5484f37',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7ba78475',
14
14
'differential.pkg.js' => 'd0cd0df6',
···
244
244
'rsrc/externals/javelin/lib/URI.js' => 'c989ade3',
245
245
'rsrc/externals/javelin/lib/Vector.js' => '2caa8fb8',
246
246
'rsrc/externals/javelin/lib/WebSocket.js' => 'e292eaf4',
247
-
'rsrc/externals/javelin/lib/Workflow.js' => '5b2e3e2b',
247
+
'rsrc/externals/javelin/lib/Workflow.js' => '28cfbdd0',
248
248
'rsrc/externals/javelin/lib/__tests__/Cookie.js' => '5ed109e8',
249
249
'rsrc/externals/javelin/lib/__tests__/DOM.js' => 'c984504b',
250
250
'rsrc/externals/javelin/lib/__tests__/JSON.js' => '837a7d68',
···
734
734
'javelin-workboard-card' => 'c587b80f',
735
735
'javelin-workboard-column' => 'bae58312',
736
736
'javelin-workboard-controller' => '55baf5ed',
737
-
'javelin-workflow' => '5b2e3e2b',
737
+
'javelin-workflow' => '28cfbdd0',
738
738
'lightbox-attachment-css' => '7acac05d',
739
739
'maniphest-batch-editor' => 'b0f0b6d5',
740
740
'maniphest-report-css' => '9b9580b7',
···
1059
1059
'phabricator-drag-and-drop-file-upload',
1060
1060
'phabricator-draggable-list',
1061
1061
),
1062
+
'28cfbdd0' => array(
1063
+
'javelin-stratcom',
1064
+
'javelin-request',
1065
+
'javelin-dom',
1066
+
'javelin-vector',
1067
+
'javelin-install',
1068
+
'javelin-util',
1069
+
'javelin-mask',
1070
+
'javelin-uri',
1071
+
'javelin-routable',
1072
+
),
1062
1073
'2926fff2' => array(
1063
1074
'javelin-behavior',
1064
1075
'javelin-dom',
···
1311
1322
'javelin-util',
1312
1323
'javelin-vector',
1313
1324
'javelin-magical-init',
1314
-
),
1315
-
'5b2e3e2b' => array(
1316
-
'javelin-stratcom',
1317
-
'javelin-request',
1318
-
'javelin-dom',
1319
-
'javelin-vector',
1320
-
'javelin-install',
1321
-
'javelin-util',
1322
-
'javelin-mask',
1323
-
'javelin-uri',
1324
-
'javelin-routable',
1325
1325
),
1326
1326
'5c54cbf3' => array(
1327
1327
'javelin-behavior',
+1
-1
webroot/rsrc/externals/javelin/lib/Workflow.js
+1
-1
webroot/rsrc/externals/javelin/lib/Workflow.js
···
192
192
// Use more space if the dialog is large (at least roughly the size
193
193
// of the viewport).
194
194
var offset = Math.min(Math.max(20, (v.y - d.y) / 2), 100);
195
-
JX.$V((v.x - d.x) / 2, s.y + offset).setPos(this._root);
195
+
JX.$V(0, s.y + offset).setPos(this._root);
196
196
197
197
try {
198
198
JX.DOM.focus(JX.DOM.find(this._root, 'button', '__default__'));