@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Removie panelview backgrounds from Herald.
Summary: Prior to re-doing responsive form CSS, update the Herald app for no panel backgrounds.
Test Plan: Went through Herald application, see no panels.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4545
+18
-11
+1
src/applications/herald/controller/HeraldHomeController.php
+1
src/applications/herald/controller/HeraldHomeController.php
+4
-3
src/applications/herald/controller/HeraldNewController.php
+4
-3
src/applications/herald/controller/HeraldNewController.php
···
59
59
->setAction('/herald/rule/')
60
60
->appendChild(
61
61
id(new AphrontFormSelectControl())
62
-
->setLabel('New rule for')
62
+
->setLabel(pht('New rule for'))
63
63
->setName('content_type')
64
64
->setValue($this->contentType)
65
65
->setOptions($content_type_map))
66
66
->appendChild($radio)
67
67
->appendChild(
68
68
id(new AphrontFormSubmitControl())
69
-
->setValue('Create Rule')
69
+
->setValue(pht('Create Rule'))
70
70
->addCancelButton('/herald/view/'.$this->contentType.'/'));
71
71
72
72
$panel = new AphrontPanelView();
73
-
$panel->setHeader('Create New Herald Rule');
73
+
$panel->setHeader(pht('Create New Herald Rule'));
74
74
$panel->setWidth(AphrontPanelView::WIDTH_FULL);
75
75
$panel->appendChild($form);
76
+
$panel->setNoBackground();
76
77
77
78
$nav = $this->renderNav();
78
79
$nav->selectFilter('new');
+3
-2
src/applications/herald/controller/HeraldRuleController.php
+3
-2
src/applications/herald/controller/HeraldRuleController.php
···
173
173
$panel = new AphrontPanelView();
174
174
$panel->setHeader(
175
175
$rule->getID()
176
-
? 'Edit Herald Rule'
177
-
: 'Create Herald Rule');
176
+
? pht('Edit Herald Rule')
177
+
: pht('Create Herald Rule'));
178
178
$panel->setWidth(AphrontPanelView::WIDTH_WIDE);
179
179
$panel->appendChild($form);
180
+
$panel->setNoBackground();
180
181
181
182
$nav = $this->renderNav();
182
183
$nav->selectFilter(
+2
-1
src/applications/herald/controller/HeraldRuleEditHistoryController.php
+2
-1
src/applications/herald/controller/HeraldRuleEditHistoryController.php
···
31
31
->setUser($this->getRequest()->getUser());
32
32
33
33
$panel = new AphrontPanelView();
34
-
$panel->setHeader('Edit History');
34
+
$panel->setHeader(pht('Edit History'));
35
35
$panel->appendChild($list_view);
36
+
$panel->setNoBackground();
36
37
37
38
$nav = $this->renderNav();
38
39
$nav->selectFilter('history');
+4
-3
src/applications/herald/controller/HeraldTestConsoleController.php
+4
-3
src/applications/herald/controller/HeraldTestConsoleController.php
···
103
103
'results of a dry run on the object.</p>')
104
104
->appendChild(
105
105
id(new AphrontFormTextControl())
106
-
->setLabel('Object Name')
106
+
->setLabel(pht('Object Name'))
107
107
->setName('object_name')
108
108
->setError($e_name)
109
109
->setValue($object_name))
110
110
->appendChild(
111
111
id(new AphrontFormSubmitControl())
112
-
->setValue('Test Rules'));
112
+
->setValue(pht('Test Rules')));
113
113
114
114
$panel = new AphrontPanelView();
115
-
$panel->setHeader('Test Herald Rules');
115
+
$panel->setHeader(pht('Test Herald Rules'));
116
116
$panel->setWidth(AphrontPanelView::WIDTH_FULL);
117
117
$panel->appendChild($form);
118
+
$panel->setNoBackground();
118
119
119
120
$nav = $this->renderNav();
120
121
$nav->selectFilter('test');
+2
-1
src/applications/herald/controller/HeraldTranscriptController.php
+2
-1
src/applications/herald/controller/HeraldTranscriptController.php
+2
-1
src/applications/herald/controller/HeraldTranscriptListController.php
+2
-1
src/applications/herald/controller/HeraldTranscriptListController.php
···
90
90
91
91
// Render the whole page.
92
92
$panel = new AphrontPanelView();
93
-
$panel->setHeader('Herald Transcripts');
93
+
$panel->setHeader(pht('Herald Transcripts'));
94
94
$panel->appendChild($table);
95
95
$panel->appendChild($pager);
96
+
$panel->setNoBackground();
96
97
97
98
$nav = $this->renderNav();
98
99
$nav->selectFilter('transcript');