@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Lift peculiar side effect of path indexing out of indexer
Summary:
Ref T13639. Updating the affected path table has a peculiar side effect from D19426, which is a simplification of a peculiar side effect from earlier.
Don't condition Owners behavior on path index behavior.
Test Plan: Created a revision.
Maniphest Tasks: T13639
Differential Revision: https://secure.phabricator.com/D21614
+3
-7
+3
-7
src/applications/differential/editor/DifferentialTransactionEditor.php
+3
-7
src/applications/differential/editor/DifferentialTransactionEditor.php
···
349
349
case DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE:
350
350
$diff = $this->requireDiff($xaction->getNewValue(), true);
351
351
352
+
$this->ownersDiff = $diff;
353
+
$this->ownersChangesets = $diff->getChangesets();
354
+
352
355
// Update these denormalized index tables when we attach a new
353
356
// diff to a revision.
354
357
···
1297
1300
$paths = array();
1298
1301
foreach ($changesets as $changeset) {
1299
1302
$paths[] = $path_prefix.'/'.$changeset->getFilename();
1300
-
}
1301
-
1302
-
// If this change affected paths, save the changesets so we can apply
1303
-
// Owners rules to them later.
1304
-
if ($paths) {
1305
-
$this->ownersDiff = $diff;
1306
-
$this->ownersChangesets = $changesets;
1307
1303
}
1308
1304
1309
1305
// Mark this as also touching all parent paths, so you can see all pending