recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:59]
```

Closes T15678

Test Plan: Add and remove alt text on an image file; then go to `/feed/query/all/`

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15678

Differential Revision: https://we.phorge.it/D25481

Andre Klapper c3850a3c 4d4712b5

+2 -2
+2 -2
src/applications/files/xaction/PhabricatorFileAltTextTransaction.php
··· 50 50 $old_value = $this->getOldValue(); 51 51 $new_value = $this->getNewValue(); 52 52 53 - if (!strlen($old_value)) { 53 + if (!phutil_nonempty_string($old_value)) { 54 54 return pht( 55 55 '%s set the alternate text for %s to %s.', 56 56 $this->renderAuthor(), 57 57 $this->renderObject(), 58 58 $this->renderNewValue()); 59 - } else if (!strlen($new_value)) { 59 + } else if (!phutil_nonempty_string($new_value)) { 60 60 return pht( 61 61 '%s removed the alternate text for %s (was %s).', 62 62 $this->renderAuthor(),