@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix non-public capabilities in Application edit
Summary: Ref T603. I nuked this check by accident and neglected to test the negative case.
Test Plan: Saved a non-public policy (Herald Global) and a public policy (Maniphest View).
Reviewers: asherkin, btrahan
Reviewed By: asherkin
CC: aran
Maniphest Tasks: T603
Differential Revision: https://secure.phabricator.com/D7278
+7
-4
+7
-4
src/applications/meta/controller/PhabricatorApplicationEditController.php
+7
-4
src/applications/meta/controller/PhabricatorApplicationEditController.php
···
51
51
continue;
52
52
}
53
53
54
-
$capobj = PhabricatorPolicyCapability::getCapabilityByKey($capability);
55
-
if (!$capobj || !$capobj->shouldAllowPublicPolicySetting()) {
56
-
// Can't set non-public policies to public.
57
-
continue;
54
+
if ($new == PhabricatorPolicies::POLICY_PUBLIC) {
55
+
$capobj = PhabricatorPolicyCapability::getCapabilityByKey(
56
+
$capability);
57
+
if (!$capobj || !$capobj->shouldAllowPublicPolicySetting()) {
58
+
// Can't set non-public policies to public.
59
+
continue;
60
+
}
58
61
}
59
62
60
63
$result[$capability] = $new;