@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an out-of-date API call on the destruction pathway for Pholio mocks
Summary:
See <https://discourse.phabricator-community.org/t/destroying-a-mock-using-bin-remove-destroy-mx-gives-an-error/3728>.
Currently, Pholio calls an older API method on the mock destruction pathway. This call was introduced in D19911 but the callsite was only partially updated in D19914.
Test Plan: Ran "bin/remove destroy Mx" to destroy a mock. Before: fatal with a bad call; after: clean destruction.
Differential Revision: https://secure.phabricator.com/D21081
+1
-1
+1
-1
src/applications/pholio/storage/PholioMock.php
+1
-1
src/applications/pholio/storage/PholioMock.php
···
225
225
$this->openTransaction();
226
226
$images = id(new PholioImageQuery())
227
227
->setViewer($engine->getViewer())
228
-
->withMockIDs(array($this->getPHID()))
228
+
->withMockPHIDs(array($this->getPHID()))
229
229
->execute();
230
230
foreach ($images as $image) {
231
231
$image->delete();