@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When generating Calendar event stubs, inherit import properties
Summary:
Ref T10747. Previously, importing a recurring event failed to mark the instnaces of the event as imported.
Now, we copy the source/UID/importer over.
Test Plan: Imported a recurring event, viewed event series, saw all of them marked imported.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10747
Differential Revision: https://secure.phabricator.com/D16728
+14
-2
+14
-2
src/applications/calendar/storage/PhabricatorCalendarEvent.php
+14
-2
src/applications/calendar/storage/PhabricatorCalendarEvent.php
···
179
179
->setName($parent->getName())
180
180
->setDescription($parent->getDescription());
181
181
182
-
$sequence = $this->getSequenceIndex();
183
-
184
182
if ($start) {
185
183
$start_datetime = $start;
186
184
} else {
185
+
$sequence = $this->getSequenceIndex();
187
186
$start_datetime = $parent->newSequenceIndexDateTime($sequence);
188
187
189
188
if (!$start_datetime) {
···
200
199
$this
201
200
->setStartDateTime($start_datetime)
202
201
->setEndDateTime($end_datetime);
202
+
203
+
if ($parent->isImportedEvent()) {
204
+
$full_uid = $parent->getImportUID().'/'.$start_datetime->getEpoch();
205
+
206
+
// NOTE: We don't attach the import source because this gets called
207
+
// from CalendarEventQuery while building ghosts, before we've loaded
208
+
// and attached sources. Possibly this sequence should be flipped.
209
+
210
+
$this
211
+
->setImportAuthorPHID($parent->getImportAuthorPHID())
212
+
->setImportSourcePHID($parent->getImportSourcePHID())
213
+
->setImportUID($full_uid);
214
+
}
203
215
204
216
return $this;
205
217
}