@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't create mentions for dependent diffs
Summary:
Fixes T6858. We shouldn't create mentions for dependent diffs.
NOTE: This won't fix the issue for existing revisions (which have the mentions edge), but I think that this is harmless.
Test Plan: Added `Depends on Dxxx` to a differential summary. Saw a `josh added a dependent revision` transaction, but no explicit mention.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6858
Differential Revision: https://secure.phabricator.com/D11460
+6
-3
+6
-3
src/applications/differential/editor/DifferentialTransactionEditor.php
+6
-3
src/applications/differential/editor/DifferentialTransactionEditor.php
···
1276
1276
}
1277
1277
1278
1278
$edges = array();
1279
+
$task_phids = array();
1280
+
$rev_phids = array();
1279
1281
1280
1282
if ($task_map) {
1281
1283
$tasks = id(new ManiphestTaskQuery())
···
1284
1286
->execute();
1285
1287
1286
1288
if ($tasks) {
1287
-
$phid_map = mpull($tasks, 'getPHID', 'getPHID');
1289
+
$task_phids = mpull($tasks, 'getPHID', 'getPHID');
1288
1290
$edge_related = DifferentialRevisionHasTaskEdgeType::EDGECONST;
1289
-
$edges[$edge_related] = $phid_map;
1290
-
$this->setUnmentionablePHIDMap($phid_map);
1291
+
$edges[$edge_related] = $task_phids;
1291
1292
}
1292
1293
}
1293
1294
···
1307
1308
$edges[$depends] = $rev_phids;
1308
1309
}
1309
1310
}
1311
+
1312
+
$this->setUnmentionablePHIDMap(array_merge($task_phids, $rev_phids));
1310
1313
1311
1314
$result = array();
1312
1315
foreach ($edges as $type => $specs) {