recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Respect "disabled" custom field status granted by "subtype" configuration in form validation

Summary:
Fixes T13384. Currently, the subtype "disabled" configuration is not respected when selecting fields for `ROLE_EDIT`.

The only meaningful caller for `ROLE_EDIT` is transaction validation, but transaction validation should respect fields being disabled by subtype configuration.

Test Plan:
- Added a "required" Maniphest custom field "F", then "disabled" it in a subtype "S".
- Created a task of subtype "S".
- Before: Form submission fails with error "F is required", even though the field is not actually visible on the form and can not be set.
- After: Form submits cleanly and creates the task.

Maniphest Tasks: T13384

Differential Revision: https://secure.phabricator.com/D20726

epriestley c4399313 64b399d9

+1
+1
src/infrastructure/customfield/field/PhabricatorCustomField.php
··· 1648 1648 $subtype_roles = array( 1649 1649 self::ROLE_EDITENGINE, 1650 1650 self::ROLE_VIEW, 1651 + self::ROLE_EDIT, 1651 1652 ); 1652 1653 1653 1654 $subtype_roles = array_fuse($subtype_roles);