@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Display full picture in image macro editing
Summary:
Users are complaining that they don't see how the image macro looks until they use it.
Click leads to edit form.
Display it there.
Test Plan:
Edited macro.
Attempted to create macro with duplicate name.
Reviewers: epriestley
Reviewed By: epriestley
CC: chad, aran, Korvin
Differential Revision: https://secure.phabricator.com/D3636
+14
+14
src/applications/macro/controller/PhabricatorMacroEditController.php
+14
src/applications/macro/controller/PhabricatorMacroEditController.php
···
38
38
39
39
$errors = array();
40
40
$e_name = true;
41
+
$file = null;
41
42
42
43
$request = $this->getRequest();
43
44
$user = $request->getUser();
···
75
76
$e_name = 'Duplicate';
76
77
}
77
78
}
79
+
} else if ($this->id) {
80
+
$file = id(new PhabricatorFile())
81
+
->loadOneWhere('phid = %s', $macro->getFilePHID());
82
+
}
83
+
84
+
$caption = null;
85
+
if ($file) {
86
+
$caption = phutil_render_tag(
87
+
'img',
88
+
array(
89
+
'src' => $file->getViewURI(),
90
+
));
78
91
}
79
92
80
93
if ($errors) {
···
102
115
id(new AphrontFormFileControl())
103
116
->setLabel('File')
104
117
->setName('file')
118
+
->setCaption($caption)
105
119
->setError(true))
106
120
->appendChild(
107
121
id(new AphrontFormSubmitControl())