@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert attempt to fix mail in differential
Summary: This fix is wrong - should be load and not get - but moreover this is actually correctly set as the reply handler is instantiated inside the DifferentialRevisionMailReceiver correctly; $this->getExclude was correct. Ref T5185.
Test Plan: this shall stop the fatal in production.
Reviewers: chad, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T5185
Differential Revision: https://secure.phabricator.com/D10101
+4
-10
+4
-10
src/applications/differential/mail/DifferentialReplyHandler.php
+4
-10
src/applications/differential/mail/DifferentialReplyHandler.php
···
146
146
->setContent($body));
147
147
}
148
148
149
-
// NOTE: We have to be careful about this because Facebook's
150
-
// implementation jumps straight into handleAction() and will not have
151
-
// a PhabricatorMetaMTAReceivedMail object.
152
-
if ($this->receivedMail) {
153
-
$exclude = $this->receivedMail->getExcludeMailRecipientPHIDs();
154
-
} else {
155
-
$exclude = $this->getExcludeMailRecipientPHIDs();
156
-
}
157
-
158
149
$editor = id(new DifferentialTransactionEditor())
159
150
->setActor($actor)
160
-
->setExcludeMailRecipientPHIDs($exclude)
151
+
->setExcludeMailRecipientPHIDs($this->getExcludeMailRecipientPHIDs())
161
152
->setContinueOnMissingFields(true)
162
153
->setContinueOnNoEffect(true);
163
154
155
+
// NOTE: We have to be careful about this because Facebook's
156
+
// implementation jumps straight into handleAction() and will not have
157
+
// a PhabricatorMetaMTAReceivedMail object.
164
158
if ($this->receivedMail) {
165
159
$content_source = PhabricatorContentSource::newForSource(
166
160
PhabricatorContentSource::SOURCE_EMAIL,