@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove various unused beahviors from PHUIWorkboardView
Summary: Ref T5240. We don't currently use any of these options and I don't think we have any plans to use them. Strip them out for now to make fixing drag-and-drop stuff easier.
Test Plan: Grepped for removed stuff, no hits.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T5240
Differential Revision: https://secure.phabricator.com/D14864
+3
-96
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
152
152
'rsrc/css/phui/phui-text.css' => 'cf019f54',
153
153
'rsrc/css/phui/phui-timeline-view.css' => '2efceff8',
154
154
'rsrc/css/phui/phui-two-column-view.css' => '39ecafb1',
155
-
'rsrc/css/phui/phui-workboard-view.css' => '6704d68d',
155
+
'rsrc/css/phui/phui-workboard-view.css' => '24fe2a66',
156
156
'rsrc/css/phui/phui-workpanel-view.css' => 'adec7699',
157
157
'rsrc/css/sprite-login.css' => '60e8560e',
158
158
'rsrc/css/sprite-main-header.css' => 'f07bbb87',
···
828
828
'phui-theme-css' => '6b451f24',
829
829
'phui-timeline-view-css' => '2efceff8',
830
830
'phui-two-column-view-css' => '39ecafb1',
831
-
'phui-workboard-view-css' => '6704d68d',
831
+
'phui-workboard-view-css' => '24fe2a66',
832
832
'phui-workpanel-view-css' => 'adec7699',
833
833
'phuix-action-list-view' => 'b5c256b8',
834
834
'phuix-action-view' => '8cf6d262',
+1
-46
src/view/phui/PHUIWorkboardView.php
+1
-46
src/view/phui/PHUIWorkboardView.php
···
3
3
final class PHUIWorkboardView extends AphrontTagView {
4
4
5
5
private $panels = array();
6
-
private $fluidLayout = false;
7
-
private $fluidishLayout = false;
8
6
private $actions = array();
9
7
10
8
public function addPanel(PHUIWorkpanelView $panel) {
···
12
10
return $this;
13
11
}
14
12
15
-
public function setFluidLayout($layout) {
16
-
$this->fluidLayout = $layout;
17
-
return $this;
18
-
}
19
-
20
-
public function setFluidishLayout($layout) {
21
-
$this->fluidishLayout = $layout;
22
-
return $this;
23
-
}
24
-
25
-
public function addAction(PHUIIconView $action) {
26
-
$this->actions[] = $action;
27
-
return $this;
28
-
}
29
-
30
13
protected function getTagAttributes() {
31
14
return array(
32
15
'class' => 'phui-workboard-view',
···
36
19
protected function getTagContent() {
37
20
require_celerity_resource('phui-workboard-view-css');
38
21
39
-
$action_list = null;
40
-
if (!empty($this->actions)) {
41
-
$items = array();
42
-
foreach ($this->actions as $action) {
43
-
$items[] = phutil_tag(
44
-
'li',
45
-
array(
46
-
'class' => 'phui-workboard-action-item',
47
-
),
48
-
$action);
49
-
}
50
-
$action_list = phutil_tag(
51
-
'ul',
52
-
array(
53
-
'class' => 'phui-workboard-action-list',
54
-
),
55
-
$items);
56
-
}
57
-
58
22
$view = new AphrontMultiColumnView();
59
23
$view->setGutter(AphrontMultiColumnView::GUTTER_MEDIUM);
60
-
if ($this->fluidLayout) {
61
-
$view->setFluidLayout($this->fluidLayout);
62
-
}
63
-
if ($this->fluidishLayout) {
64
-
$view->setFluidishLayout($this->fluidishLayout);
65
-
}
66
24
foreach ($this->panels as $panel) {
67
25
$view->addColumn($panel);
68
26
}
···
74
32
),
75
33
$view);
76
34
77
-
return array(
78
-
$action_list,
79
-
$board,
80
-
);
35
+
return $board;
81
36
}
82
37
}
-48
webroot/rsrc/css/phui/phui-workboard-view.css
-48
webroot/rsrc/css/phui/phui-workboard-view.css
···
37
37
background: {$lightbluetext};
38
38
}
39
39
40
-
.phui-workboard-action-list {
41
-
width: 60px;
42
-
float: left;
43
-
min-height: 60px;
44
-
border-radius: 5px;
45
-
margin-right: 8px;
46
-
background: {$lightbluebackground};
47
-
border: 1px solid {$lightblueborder};
48
-
border-bottom: 1px solid {$blueborder};
49
-
}
50
-
51
-
.device-phone .phui-workboard-action-list {
52
-
width: 100%;
53
-
float: none;
54
-
display: block;
55
-
overflow: hidden;
56
-
border: none;
57
-
background: none;
58
-
border-radius: none;
59
-
min-height: 0;
60
-
}
61
-
62
-
.phui-workboard-action-list li:first-child {
63
-
padding-top: 5px;
64
-
}
65
-
66
-
.device-phone .phui-workboard-action-list li {
67
-
display: inline;
68
-
float: left;
69
-
margin: 0;
70
-
padding: 0 0 8px 0;
71
-
}
72
-
73
-
.phui-workboard-action-list .phui-icon-view {
74
-
display: inline-block;
75
-
vertical-align: top;
76
-
width: 50px;
77
-
height: 50px;
78
-
margin: 0 4px 5px 5px;
79
-
}
80
-
81
-
.device-phone .phui-workboard-action-list .phui-icon-view {
82
-
background-size: 35px;
83
-
height: 35px;
84
-
width: 35px;
85
-
margin: 0 3px;
86
-
}
87
-
88
40
.device-desktop .project-board-wrapper .phui-workboard-view-shadow {
89
41
left: 53px;
90
42
}