@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Differential - fix bogus foreach(null)
Summary: Default $phids to array() and update it if getValue() has something pertinent... Fixes T6292.
Test Plan: just used the ole logic noodle on this one.
Reviewers: chad, epriestley
Reviewed By: chad, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6292
Differential Revision: https://secure.phabricator.com/D10697
+5
-1
+5
-1
src/applications/differential/customfield/DifferentialReviewersField.php
+5
-1
src/applications/differential/customfield/DifferentialReviewersField.php
···
63
63
}
64
64
65
65
public function getRequiredHandlePHIDsForEdit() {
66
-
return mpull($this->getValue(), 'getReviewerPHID');
66
+
$phids = array();
67
+
if ($this->getValue()) {
68
+
$phids = mpull($this->getValue(), 'getReviewerPHID');
69
+
}
70
+
return $phids;
67
71
}
68
72
69
73
public function renderEditControl(array $handles) {