recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where internal Calendar DateTimes would not be correctly set to all-day

Summary:
Ref T11816. I don't really know what happened here, maybe I rewrote and broke this at the last second?

In most cases, we directly respect the `isAllDay` flag on the event, so the internal date state doesn't matter too much.

However, in the case of mail notifications, the raw internal state is relevant. This should fix mail notifications for all-day events.

(I might still turn them off since I'm not sure they're too useful, but it's good to have them working.)

Test Plan:
- Created a new all-day event, verified database values wrote correctly.
- Ran `bin/calendar notify --trace`, verified it picked up an all-day event tomorrow with a large enough `--minutes` value.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D16954

epriestley c5162074 3edd01bc

+1 -1
+1 -1
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
··· 55 55 if ($xaction->getTransactionType() != $type_allday) { 56 56 continue; 57 57 } 58 - $target_alllday = (bool)$xaction->getNewValue(); 58 + $new_allday = (bool)$xaction->getNewValue(); 59 59 } 60 60 61 61 $this->oldIsAllDay = $old_allday;