@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Basic Differential revision feedback view.
+361
-44
+32
-14
src/__celerity_resource_map__.php
+32
-14
src/__celerity_resource_map__.php
···
82
82
),
83
83
'phabricator-standard-page-view' =>
84
84
array(
85
-
'uri' => '/res/1f93ada7/rsrc/css/application/base/standard-page-view.css',
85
+
'uri' => '/res/fb02fb0e/rsrc/css/application/base/standard-page-view.css',
86
86
'type' => 'css',
87
87
'requires' =>
88
88
array(
···
106
106
array(
107
107
),
108
108
'disk' => '/rsrc/css/application/differential/core.css',
109
+
),
110
+
'differential-revision-comment-list-css' =>
111
+
array(
112
+
'uri' => '/res/a1c117db/rsrc/css/application/differential/revision-comment-list.css',
113
+
'type' => 'css',
114
+
'requires' =>
115
+
array(
116
+
),
117
+
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
118
+
),
119
+
'differential-revision-comment-css' =>
120
+
array(
121
+
'uri' => '/res/d9924857/rsrc/css/application/differential/revision-comment.css',
122
+
'type' => 'css',
123
+
'requires' =>
124
+
array(
125
+
),
126
+
'disk' => '/rsrc/css/application/differential/revision-comment.css',
109
127
),
110
128
'differential-revision-detail-css' =>
111
129
array(
···
247
265
), array (
248
266
'packages' =>
249
267
array (
250
-
'4efe7b58' =>
268
+
'364a306c' =>
251
269
array (
252
270
'name' => 'core.pkg.css',
253
271
'symbols' =>
···
264
282
9 => 'aphront-typeahead-control-css',
265
283
10 => 'phabricator-directory-css',
266
284
),
267
-
'uri' => '/res/pkg/4efe7b58/core.pkg.css',
285
+
'uri' => '/res/pkg/364a306c/core.pkg.css',
268
286
'type' => 'css',
269
287
),
270
288
'69b11588' =>
···
284
302
),
285
303
'reverse' =>
286
304
array (
287
-
'phabricator-core-css' => '4efe7b58',
288
-
'phabricator-core-buttons-css' => '4efe7b58',
289
-
'phabricator-standard-page-view' => '4efe7b58',
290
-
'aphront-dialog-view-css' => '4efe7b58',
291
-
'aphront-form-view-css' => '4efe7b58',
292
-
'aphront-panel-view-css' => '4efe7b58',
293
-
'aphront-side-nav-view-css' => '4efe7b58',
294
-
'aphront-table-view-css' => '4efe7b58',
295
-
'aphront-tokenizer-control-css' => '4efe7b58',
296
-
'aphront-typeahead-control-css' => '4efe7b58',
297
-
'phabricator-directory-css' => '4efe7b58',
305
+
'phabricator-core-css' => '364a306c',
306
+
'phabricator-core-buttons-css' => '364a306c',
307
+
'phabricator-standard-page-view' => '364a306c',
308
+
'aphront-dialog-view-css' => '364a306c',
309
+
'aphront-form-view-css' => '364a306c',
310
+
'aphront-panel-view-css' => '364a306c',
311
+
'aphront-side-nav-view-css' => '364a306c',
312
+
'aphront-table-view-css' => '364a306c',
313
+
'aphront-tokenizer-control-css' => '364a306c',
314
+
'aphront-typeahead-control-css' => '364a306c',
315
+
'phabricator-directory-css' => '364a306c',
298
316
'differential-core-view-css' => '69b11588',
299
317
'differential-changeset-view-css' => '69b11588',
300
318
'differential-revision-detail-css' => '69b11588',
+6
src/__phutil_library_map__.php
+6
src/__phutil_library_map__.php
···
72
72
'DifferentialChangesetListView' => 'applications/differential/view/changesetlistview',
73
73
'DifferentialChangesetParser' => 'applications/differential/parser/changeset',
74
74
'DifferentialChangesetViewController' => 'applications/differential/controller/changesetview',
75
+
'DifferentialComment' => 'applications/differential/storage/comment',
75
76
'DifferentialController' => 'applications/differential/controller/base',
76
77
'DifferentialDAO' => 'applications/differential/storage/base',
77
78
'DifferentialDiff' => 'applications/differential/storage/diff',
···
86
87
'DifferentialNewDiffMail' => 'applications/differential/mail/newdiff',
87
88
'DifferentialReviewRequestMail' => 'applications/differential/mail/reviewrequest',
88
89
'DifferentialRevision' => 'applications/differential/storage/revision',
90
+
'DifferentialRevisionCommentListView' => 'applications/differential/view/revisioncommentlist',
91
+
'DifferentialRevisionCommentView' => 'applications/differential/view/revisioncomment',
89
92
'DifferentialRevisionControlSystem' => 'applications/differential/constants/revisioncontrolsystem',
90
93
'DifferentialRevisionDetailView' => 'applications/differential/view/revisiondetail',
91
94
'DifferentialRevisionEditController' => 'applications/differential/controller/revisionedit',
···
226
229
'DifferentialChangesetDetailView' => 'AphrontView',
227
230
'DifferentialChangesetListView' => 'AphrontView',
228
231
'DifferentialChangesetViewController' => 'DifferentialController',
232
+
'DifferentialComment' => 'DifferentialDAO',
229
233
'DifferentialController' => 'PhabricatorController',
230
234
'DifferentialDAO' => 'PhabricatorLiskDAO',
231
235
'DifferentialDiff' => 'DifferentialDAO',
···
238
242
'DifferentialNewDiffMail' => 'DifferentialReviewRequestMail',
239
243
'DifferentialReviewRequestMail' => 'DifferentialMail',
240
244
'DifferentialRevision' => 'DifferentialDAO',
245
+
'DifferentialRevisionCommentListView' => 'AphrontView',
246
+
'DifferentialRevisionCommentView' => 'AphrontView',
241
247
'DifferentialRevisionDetailView' => 'AphrontView',
242
248
'DifferentialRevisionEditController' => 'DifferentialController',
243
249
'DifferentialRevisionListController' => 'DifferentialController',
+2
-2
src/applications/conduit/method/differential/creatediff/ConduitAPI_differential_creatediff_Method.php
+2
-2
src/applications/conduit/method/differential/creatediff/ConduitAPI_differential_creatediff_Method.php
···
33
33
'sourceControlBaseRevision' => 'required string',
34
34
'parentRevisionID' => 'optional revisionid',
35
35
'creationMethod' => 'optional string',
36
-
'ownerPHID' => 'optional phid',
36
+
'authorPHID' => 'optional phid',
37
37
'arcanistProject' => 'optional string',
38
38
'lintStatus' =>
39
39
'required enum<none, skip, okay, warn, fail>',
···
65
65
66
66
$diff->setBranch($request->getValue('branch'));
67
67
$diff->setCreationMethod($request->getValue('creationMethod'));
68
-
$diff->setOwnerPHID($request->getValue('ownerPHID'));
68
+
$diff->setAuthorPHID($request->getValue('authorPHID'));
69
69
70
70
$parent_id = $request->getValue('parentRevisionID');
71
71
if ($parent_id) {
+1
-1
src/applications/differential/constants/action/DifferentialAction.php
+1
-1
src/applications/differential/constants/action/DifferentialAction.php
+1
-1
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
+1
-1
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
···
145
145
phutil_escape_html($revision->getTitle())),
146
146
phutil_escape_html($status),
147
147
number_format($revision->getLineCount()),
148
-
$revision->getOwnerPHID(),
148
+
$revision->getAuthorPHID(),
149
149
'TODO',
150
150
$revision->getDateModified(),
151
151
$revision->getDateCreated(),
+50
-13
src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
+50
-13
src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
···
41
41
42
42
$changesets = $target->loadChangesets();
43
43
44
+
$comments = $revision->loadComments();
45
+
$comments = array_merge(
46
+
$this->getImplicitComments($revision),
47
+
$comments);
48
+
44
49
$object_phids = array_merge(
45
50
$revision->getReviewers(),
46
51
$revision->getCCPHIDs(),
47
52
array(
48
-
$revision->getOwnerPHID(),
53
+
$revision->getAuthorPHID(),
49
54
$request->getUser()->getPHID(),
50
-
));
55
+
),
56
+
mpull($comments, 'getAuthorPHID'));
51
57
52
58
$handles = id(new PhabricatorObjectHandleData($object_phids))
53
59
->loadHandles();
54
60
55
-
$diff_history = new DifferentialRevisionUpdateHistoryView();
56
-
$diff_history->setDiffs($diffs);
57
-
58
-
$toc_view = new DifferentialDiffTableOfContentsView();
59
-
$toc_view->setChangesets($changesets);
60
-
61
-
$changeset_view = new DifferentialChangesetListView();
62
-
$changeset_view->setChangesets($changesets);
63
-
64
61
$revision_detail = new DifferentialRevisionDetailView();
65
62
$revision_detail->setRevision($revision);
66
63
···
69
66
70
67
$actions = $this->getRevisionActions($revision);
71
68
$revision_detail->setActions($actions);
69
+
70
+
$comment_view = new DifferentialRevisionCommentListView();
71
+
$comment_view->setComments($comments);
72
+
$comment_view->setHandles($handles);
73
+
74
+
$diff_history = new DifferentialRevisionUpdateHistoryView();
75
+
$diff_history->setDiffs($diffs);
76
+
77
+
$toc_view = new DifferentialDiffTableOfContentsView();
78
+
$toc_view->setChangesets($changesets);
79
+
80
+
$changeset_view = new DifferentialChangesetListView();
81
+
$changeset_view->setChangesets($changesets);
72
82
73
83
return $this->buildStandardPageResponse(
74
84
'<div class="differential-primary-pane">'.
75
85
$revision_detail->render().
86
+
$comment_view->render().
76
87
$diff_history->render().
77
88
$toc_view->render().
78
89
$changeset_view->render().
···
82
93
));
83
94
}
84
95
96
+
private function getImplicitComments(DifferentialRevision $revision) {
97
+
98
+
$template = new DifferentialComment();
99
+
$template->setAuthorPHID($revision->getAuthorPHID());
100
+
$template->setRevisionID($revision->getID());
101
+
$template->setDateCreated($revision->getDateCreated());
102
+
103
+
$comments = array();
104
+
105
+
if (strlen($revision->getSummary())) {
106
+
$summary_comment = clone $template;
107
+
$summary_comment->setContent($revision->getSummary());
108
+
$summary_comment->setAction(DifferentialAction::ACTION_SUMMARIZE);
109
+
$comments[] = $summary_comment;
110
+
}
111
+
112
+
if (strlen($revision->getTestPlan())) {
113
+
$testplan_comment = clone $template;
114
+
$testplan_comment->setContent($revision->getTestPlan());
115
+
$testplan_comment->setAction(DifferentialAction::ACTION_TESTPLAN);
116
+
$comments[] = $testplan_comment;
117
+
}
118
+
119
+
return $comments;
120
+
}
121
+
85
122
private function getRevisionProperties(
86
123
DifferentialRevision $revision,
87
124
DifferentialDiff $diff,
···
93
130
$status = DifferentialRevisionStatus::getNameForRevisionStatus($status);
94
131
$properties['Revision Status'] = '<strong>'.$status.'</strong>';
95
132
96
-
$author = $handles[$revision->getOwnerPHID()];
133
+
$author = $handles[$revision->getAuthorPHID()];
97
134
$properties['Author'] = $author->renderLink();
98
135
99
136
$properties['Reviewers'] = $this->renderHandleLinkList(
···
125
162
126
163
private function getRevisionActions(DifferentialRevision $revision) {
127
164
$viewer_phid = $this->getRequest()->getUser()->getPHID();
128
-
$viewer_is_owner = ($revision->getOwnerPHID() == $viewer_phid);
165
+
$viewer_is_owner = ($revision->getAuthorPHID() == $viewer_phid);
129
166
$viewer_is_reviewer = in_array($viewer_phid, $revision->getReviewers());
130
167
$viewer_is_cc = in_array($viewer_phid, $revision->getCCPHIDs());
131
168
$status = $revision->getStatus();
+3
src/applications/differential/controller/revisionview/__init__.php
+3
src/applications/differential/controller/revisionview/__init__.php
···
7
7
8
8
9
9
phutil_require_module('phabricator', 'aphront/response/404');
10
+
phutil_require_module('phabricator', 'applications/differential/constants/action');
10
11
phutil_require_module('phabricator', 'applications/differential/constants/revisionstatus');
11
12
phutil_require_module('phabricator', 'applications/differential/controller/base');
13
+
phutil_require_module('phabricator', 'applications/differential/storage/comment');
12
14
phutil_require_module('phabricator', 'applications/differential/storage/revision');
13
15
phutil_require_module('phabricator', 'applications/differential/view/changesetlistview');
14
16
phutil_require_module('phabricator', 'applications/differential/view/difftableofcontents');
17
+
phutil_require_module('phabricator', 'applications/differential/view/revisioncommentlist');
15
18
phutil_require_module('phabricator', 'applications/differential/view/revisiondetail');
16
19
phutil_require_module('phabricator', 'applications/differential/view/revisionupdatehistory');
17
20
phutil_require_module('phabricator', 'applications/phid/handle/data');
+6
-6
src/applications/differential/data/revisionlist/DifferentialRevisionListData.php
+6
-6
src/applications/differential/data/revisionlist/DifferentialRevisionListData.php
···
60
60
break;
61
61
case self::QUERY_OPEN_OWNED:
62
62
$this->revisions = $this->loadAllWhere(
63
-
'revision.status in (%Ld) AND revision.ownerPHID in (%Ls)',
63
+
'revision.status in (%Ld) AND revision.authorPHID in (%Ls)',
64
64
$this->getOpenStatuses(),
65
65
$this->ids);
66
66
break;
67
67
case self::QUERY_COMMITTABLE:
68
68
$this->revisions = $this->loadAllWhere(
69
-
'revision.status in (%Ld) AND revision.ownerPHID in (%Ls)',
69
+
'revision.status in (%Ld) AND revision.authorPHID in (%Ls)',
70
70
array(
71
71
DifferentialRevisionStatus::ACCEPTED,
72
72
),
···
85
85
break;
86
86
case self::QUERY_OWNED:
87
87
$this->revisions = $this->loadAllWhere(
88
-
'revision.ownerPHID in (%Ls)',
88
+
'revision.authorPHID in (%Ls)',
89
89
$this->ids);
90
90
break;
91
91
case self::QUERY_OWNED_OR_REVIEWER:
92
92
$this->revisions = $this->loadAllWhereJoinReview(
93
-
'revision.ownerPHID in (%Ls) OR relationship.objectPHID in (%Ls)',
93
+
'revision.authorPHID in (%Ls) OR relationship.objectPHID in (%Ls)',
94
94
$this->ids,
95
95
$this->ids);
96
96
break;
···
99
99
$data = queryfx_all(
100
100
$rev->establishConnection('r'),
101
101
'SELECT revision.* FROM %T revision
102
-
WHERE revision.ownerPHID in (%Ls)
102
+
WHERE revision.authorPHID in (%Ls)
103
103
AND revision.status in (%Ld)
104
104
105
105
UNION ALL
···
135
135
$data = queryfx_all(
136
136
$rev->establishConnection('r'),
137
137
'SELECT revision.* FROM %T revision
138
-
WHERE revision.ownerPHID in (%Ls)
138
+
WHERE revision.authorPHID in (%Ls)
139
139
AND revision.status IN (%Ld)
140
140
141
141
UNION ALL
+3
-3
src/applications/differential/editor/revision/DifferentialRevisionEditor.php
+3
-3
src/applications/differential/editor/revision/DifferentialRevisionEditor.php
···
204
204
if ($revision->getTitle() === null) {
205
205
$revision->setTitle('Untitled Revision');
206
206
}
207
-
if ($revision->getOwnerPHID() === null) {
208
-
$revision->setOwnerPHID($this->getActorPHID());
207
+
if ($revision->getAuthorPHID() === null) {
208
+
$revision->setAuthorPHID($this->getActorPHID());
209
209
}
210
210
211
211
$revision->save();
···
315
315
array_keys($add['rev']),
316
316
$this->actorPHID);
317
317
318
-
// Add the owner to the relevant set of users so they get a copy of the
318
+
// Add the author to the relevant set of users so they get a copy of the
319
319
// email.
320
320
if (!$this->silentUpdate) {
321
321
if ($is_new) {
+26
src/applications/differential/storage/comment/DifferentialComment.php
+26
src/applications/differential/storage/comment/DifferentialComment.php
···
1
+
<?php
2
+
3
+
/*
4
+
* Copyright 2011 Facebook, Inc.
5
+
*
6
+
* Licensed under the Apache License, Version 2.0 (the "License");
7
+
* you may not use this file except in compliance with the License.
8
+
* You may obtain a copy of the License at
9
+
*
10
+
* http://www.apache.org/licenses/LICENSE-2.0
11
+
*
12
+
* Unless required by applicable law or agreed to in writing, software
13
+
* distributed under the License is distributed on an "AS IS" BASIS,
14
+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+
* See the License for the specific language governing permissions and
16
+
* limitations under the License.
17
+
*/
18
+
19
+
class DifferentialComment extends DifferentialDAO {
20
+
21
+
protected $authorPHID;
22
+
protected $revisionID;
23
+
protected $action;
24
+
protected $content;
25
+
26
+
}
+12
src/applications/differential/storage/comment/__init__.php
+12
src/applications/differential/storage/comment/__init__.php
+1
-1
src/applications/differential/storage/diff/DifferentialDiff.php
+1
-1
src/applications/differential/storage/diff/DifferentialDiff.php
+10
-1
src/applications/differential/storage/revision/DifferentialRevision.php
+10
-1
src/applications/differential/storage/revision/DifferentialRevision.php
···
27
27
protected $blameRevision;
28
28
29
29
protected $phid;
30
-
protected $ownerPHID;
30
+
protected $authorPHID;
31
31
32
32
protected $dateCommitted;
33
33
···
56
56
return array();
57
57
}
58
58
return id(new DifferentialDiff())->loadAllWhere(
59
+
'revisionID = %d',
60
+
$this->getID());
61
+
}
62
+
63
+
public function loadComments() {
64
+
if (!$this->getID()) {
65
+
return array();
66
+
}
67
+
return id(new DifferentialComment())->loadAllWhere(
59
68
'revisionID = %d',
60
69
$this->getID());
61
70
}
+1
src/applications/differential/storage/revision/__init__.php
+1
src/applications/differential/storage/revision/__init__.php
···
7
7
8
8
9
9
phutil_require_module('phabricator', 'applications/differential/storage/base');
10
+
phutil_require_module('phabricator', 'applications/differential/storage/comment');
10
11
phutil_require_module('phabricator', 'applications/differential/storage/diff');
11
12
phutil_require_module('phabricator', 'applications/phid/storage/phid');
12
13
phutil_require_module('phabricator', 'storage/qsprintf');
+80
src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
+80
src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
···
1
+
<?php
2
+
3
+
/*
4
+
* Copyright 2011 Facebook, Inc.
5
+
*
6
+
* Licensed under the Apache License, Version 2.0 (the "License");
7
+
* you may not use this file except in compliance with the License.
8
+
* You may obtain a copy of the License at
9
+
*
10
+
* http://www.apache.org/licenses/LICENSE-2.0
11
+
*
12
+
* Unless required by applicable law or agreed to in writing, software
13
+
* distributed under the License is distributed on an "AS IS" BASIS,
14
+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+
* See the License for the specific language governing permissions and
16
+
* limitations under the License.
17
+
*/
18
+
19
+
final class DifferentialRevisionCommentView extends AphrontView {
20
+
21
+
private $comment;
22
+
private $handles;
23
+
24
+
public function setComment($comment) {
25
+
$this->comment = $comment;
26
+
return $this;
27
+
}
28
+
29
+
public function setHandles(array $handles) {
30
+
$this->handles = $handles;
31
+
return $this;
32
+
}
33
+
34
+
public function render() {
35
+
36
+
require_celerity_resource('differential-revision-comment-css');
37
+
38
+
$comment = $this->comment;
39
+
40
+
$action = $comment->getAction();
41
+
42
+
$action_class = 'differential-comment-action-'.phutil_escape_html($action);
43
+
44
+
$date = date('F jS, Y g:i:s A', $comment->getDateCreated());
45
+
46
+
$author = $comment->getAuthorPHID();
47
+
$author = $this->handles[$author]->renderLink();
48
+
49
+
$verb = DifferentialAction::getActionVerb($comment->getAction());
50
+
$verb = phutil_escape_html($verb);
51
+
52
+
$content = $comment->getContent();
53
+
if (strlen(rtrim($content))) {
54
+
$title = "{$author} {$verb} this revision:";
55
+
$content = phutil_escape_html($content);
56
+
} else {
57
+
$title = null;
58
+
$content =
59
+
'<div class="differential-comment-nocontent">'.
60
+
"<p>{$author} {$verb} this revision.</p>".
61
+
'</div>';
62
+
}
63
+
64
+
return
65
+
'<div class="differential-comment '.$action_class.'">'.
66
+
'<div class="differential-comment-head">'.
67
+
'<div class="differential-comment-date">'.$date.'</div>'.
68
+
'<div class="differential-comment-title">'.$title.'</div>'.
69
+
'</div>'.
70
+
'<div class="differential-comment-body">'.
71
+
'<div class="differential-comment-core">'.
72
+
'<div class="differential-comment-content">'.
73
+
$content.
74
+
'</div>'.
75
+
'</div>'.
76
+
'</div>'.
77
+
'</div>';
78
+
}
79
+
80
+
}
+16
src/applications/differential/view/revisioncomment/__init__.php
+16
src/applications/differential/view/revisioncomment/__init__.php
···
1
+
<?php
2
+
/**
3
+
* This file is automatically generated. Lint this module to rebuild it.
4
+
* @generated
5
+
*/
6
+
7
+
8
+
9
+
phutil_require_module('phabricator', 'applications/differential/constants/action');
10
+
phutil_require_module('phabricator', 'infratructure/celerity/api');
11
+
phutil_require_module('phabricator', 'view/base');
12
+
13
+
phutil_require_module('phutil', 'markup');
14
+
15
+
16
+
phutil_require_source('DifferentialRevisionCommentView.php');
+52
src/applications/differential/view/revisioncommentlist/DifferentialRevisionCommentListView.php
+52
src/applications/differential/view/revisioncommentlist/DifferentialRevisionCommentListView.php
···
1
1
+
<?php
2
2
+
3
3
+
/*
4
4
+
* Copyright 2011 Facebook, Inc.
5
5
+
*
6
6
+
* Licensed under the Apache License, Version 2.0 (the "License");
7
7
+
* you may not use this file except in compliance with the License.
8
8
+
* You may obtain a copy of the License at
9
9
+
*
10
10
+
* http://www.apache.org/licenses/LICENSE-2.0
11
11
+
*
12
12
+
* Unless required by applicable law or agreed to in writing, software
13
13
+
* distributed under the License is distributed on an "AS IS" BASIS,
14
14
+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
15
+
* See the License for the specific language governing permissions and
16
16
+
* limitations under the License.
17
17
+
*/
18
18
+
19
19
+
final class DifferentialRevisionCommentListView extends AphrontView {
20
20
+
21
21
+
private $comments;
22
22
+
private $handles;
23
23
+
24
24
+
public function setComments($comments) {
25
25
+
$this->comments = $comments;
26
26
+
return $this;
27
27
+
}
28
28
+
29
29
+
public function setHandles(array $handles) {
30
30
+
$this->handles = $handles;
31
31
+
return $this;
32
32
+
}
33
33
+
34
34
+
public function render() {
35
35
+
36
36
+
require_celerity_resource('differential-revision-comment-list-css');
37
37
+
38
38
+
$comments = array();
39
39
+
foreach ($this->comments as $comment) {
40
40
+
$view = new DifferentialRevisionCommentView();
41
41
+
$view->setComment($comment);
42
42
+
$view->setHandles($this->handles);
43
43
+
44
44
+
$comments[] = $view->render();
45
45
+
}
46
46
+
47
47
+
return
48
48
+
'<div>'.
49
49
+
implode("\n", $comments).
50
50
+
'</div>';
51
51
+
}
52
52
+
}
+14
src/applications/differential/view/revisioncommentlist/__init__.php
+14
src/applications/differential/view/revisioncommentlist/__init__.php
···
1
+
<?php
2
+
/**
3
+
* This file is automatically generated. Lint this module to rebuild it.
4
+
* @generated
5
+
*/
6
+
7
+
8
+
9
+
phutil_require_module('phabricator', 'applications/differential/view/revisioncomment');
10
+
phutil_require_module('phabricator', 'infratructure/celerity/api');
11
+
phutil_require_module('phabricator', 'view/base');
12
+
13
+
14
+
phutil_require_source('DifferentialRevisionCommentListView.php');
+1
-1
src/view/page/failure/AphrontRequestFailureView.php
+1
-1
src/view/page/failure/AphrontRequestFailureView.php
+1
src/view/page/failure/__init__.php
+1
src/view/page/failure/__init__.php
-1
webroot/rsrc/css/application/base/standard-page-view.css
-1
webroot/rsrc/css/application/base/standard-page-view.css
+4
webroot/rsrc/css/application/differential/revision-comment-list.css
+4
webroot/rsrc/css/application/differential/revision-comment-list.css
+39
webroot/rsrc/css/application/differential/revision-comment.css
+39
webroot/rsrc/css/application/differential/revision-comment.css
···
1
+
/**
2
+
* @provides differential-revision-comment-css
3
+
*/
4
+
5
+
6
+
.differential-comment-date {
7
+
color: #666666;
8
+
float: right;
9
+
font-size: 11px;
10
+
margin: 0em;
11
+
padding-top: 6px;
12
+
}
13
+
14
+
.differential-comment-title {
15
+
font-weight: bold;
16
+
height: 16px;
17
+
margin: 4px 0em 0em 0em;
18
+
padding: 4px 0em;
19
+
position: relative;
20
+
}
21
+
22
+
.differential-comment-body {
23
+
min-height: 56px;
24
+
padding-left: 62px;
25
+
background-repeat: no-repeat;
26
+
background-position: 6px 0px;
27
+
margin-bottom: 14px;
28
+
}
29
+
30
+
.differential-comment-content {
31
+
background: #fbfbfb;
32
+
border-color: #c3c3c3;
33
+
border-style: solid;
34
+
border-width: 1px 10px 1px 10px;
35
+
clear: both;
36
+
line-height: 1.4em;
37
+
margin: 0em;
38
+
padding: .3em 5px .4em 1.25em;
39
+
}