@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Only load refs that are actual commits
Summary: Fix T11301. Git is git.
Test Plan: tagged a file! run discover. no crash.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin
Maniphest Tasks: T11301
Differential Revision: https://secure.phabricator.com/D16261
+6
-4
+5
-4
src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
+5
-4
src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
···
174
174
continue;
175
175
}
176
176
177
-
// In Git, it's possible to tag a tag. We just skip these, we'll discover
178
-
// them when we process the target tag. See T11180.
177
+
// In Git, it's possible to tag anything. We just skip tags that don't
178
+
// point to a commit. See T11301.
179
179
$fields = $ref->getRawFields();
180
+
$ref_type = idx($fields, 'objecttype');
180
181
$tag_type = idx($fields, '*objecttype');
181
-
if ($tag_type == 'tag') {
182
-
$this->log(pht('Skipping, this is a tag of a tag.'));
182
+
if ($ref_type != 'commit' && $tag_type != 'commit') {
183
+
$this->log(pht('Skipping, this is not a commit.'));
183
184
continue;
184
185
}
185
186
+1
src/applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php
+1
src/applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php
src/applications/repository/engine/__tests__/data/GT.git.tgz
src/applications/repository/engine/__tests__/data/GT.git.tgz
This is a binary file and will not be displayed.