@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Unify user-select CSS directives

Summary:
Removes the -khtml, -moz and -ms prefix, since most Browsers are natively supporting the user select directive.
The -webkit prefix is still kept or added for Safari, wich does not support user-select.

Ref: see https://we.phorge.it/D25024#815 for context

Test Plan: Removing the CSS should change nothing in modern browsers.

Reviewers: O1 Blessed Committers, speck, valerio.bozzolan, Matthew

Reviewed By: O1 Blessed Committers, speck, valerio.bozzolan

Subscribers: Cigaryno, Matthew, speck, tobiaswiese, valerio.bozzolan

Differential Revision: https://we.phorge.it/D25025

authored by

Leon Eckardt and committed by
Valerio Bozzolan
c5a365e1 5405134f

+29 -50
+25 -25
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '0e3cf785', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '2ba11212', 12 + 'core.pkg.css' => '0cb47e9d', 13 13 'core.pkg.js' => '2eeda9e0', 14 14 'dark-console.pkg.js' => '187792c2', 15 - 'differential.pkg.css' => '609e63d4', 15 + 'differential.pkg.css' => '525f9a1d', 16 16 'differential.pkg.js' => '46fcb3af', 17 17 'diffusion.pkg.css' => '42c75c37', 18 18 'diffusion.pkg.js' => '78c9885d', ··· 41 41 'rsrc/css/application/base/main-menu-view.css' => '89fc16b6', 42 42 'rsrc/css/application/base/notification-menu.css' => '4df1ee30', 43 43 'rsrc/css/application/base/phui-theme.css' => '35883b37', 44 - 'rsrc/css/application/base/standard-page-view.css' => 'a374f94c', 44 + 'rsrc/css/application/base/standard-page-view.css' => 'e08c7462', 45 45 'rsrc/css/application/chatlog/chatlog.css' => 'abdc76ee', 46 46 'rsrc/css/application/conduit/conduit-api.css' => 'ce2cfc41', 47 47 'rsrc/css/application/config/config-options.css' => '16c920ae', ··· 63 63 'rsrc/css/application/diff/diff-tree-view.css' => 'e2d3e222', 64 64 'rsrc/css/application/diff/inline-comment-summary.css' => '81eb368d', 65 65 'rsrc/css/application/differential/add-comment.css' => '7e5900d9', 66 - 'rsrc/css/application/differential/changeset-view.css' => 'bf159129', 66 + 'rsrc/css/application/differential/changeset-view.css' => '8b9caefe', 67 67 'rsrc/css/application/differential/core.css' => '7300a73e', 68 68 'rsrc/css/application/differential/phui-inline-comment.css' => 'a864426f', 69 69 'rsrc/css/application/differential/revision-comment.css' => '7dbc8d1d', ··· 77 77 'rsrc/css/application/feed/feed.css' => 'd8b6e3f8', 78 78 'rsrc/css/application/files/global-drag-and-drop.css' => '1d2713a4', 79 79 'rsrc/css/application/flag/flag.css' => '2b77be8d', 80 - 'rsrc/css/application/harbormaster/harbormaster.css' => 'd98decda', 80 + 'rsrc/css/application/harbormaster/harbormaster.css' => 'cd0ce059', 81 81 'rsrc/css/application/herald/herald-test.css' => '7e7bbdae', 82 82 'rsrc/css/application/herald/herald.css' => '648d39e2', 83 83 'rsrc/css/application/maniphest/report.css' => '3d53188b', ··· 110 110 'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd', 111 111 'rsrc/css/application/uiexample/example.css' => 'b4795059', 112 112 'rsrc/css/core/core.css' => 'a708bd25', 113 - 'rsrc/css/core/remarkup.css' => '5baa3bd9', 113 + 'rsrc/css/core/remarkup.css' => '3480e1fe', 114 114 'rsrc/css/core/syntax.css' => '548567f6', 115 115 'rsrc/css/core/z-index.css' => 'ac3bfcd4', 116 116 'rsrc/css/diviner/diviner-shared.css' => '4bd263b0', ··· 121 121 'rsrc/css/fuel/fuel-handle-list.css' => '2c4cbeca', 122 122 'rsrc/css/fuel/fuel-map.css' => 'd6e31510', 123 123 'rsrc/css/fuel/fuel-menu.css' => '21f5d199', 124 - 'rsrc/css/layout/phabricator-source-code-view.css' => '6b31244f', 124 + 'rsrc/css/layout/phabricator-source-code-view.css' => '49656486', 125 125 'rsrc/css/phui/button/phui-button-bar.css' => 'a4aa75c4', 126 126 'rsrc/css/phui/button/phui-button-simple.css' => '1ff278aa', 127 - 'rsrc/css/phui/button/phui-button.css' => 'e434f171', 127 + 'rsrc/css/phui/button/phui-button.css' => 'f9d0f9c8', 128 128 'rsrc/css/phui/calendar/phui-calendar-day.css' => '9597d706', 129 129 'rsrc/css/phui/calendar/phui-calendar-list.css' => 'ccd7e4e2', 130 130 'rsrc/css/phui/calendar/phui-calendar-month.css' => 'cb758c42', ··· 133 133 'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0', 134 134 'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc', 135 135 'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e', 136 - 'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'af98a277', 136 + 'rsrc/css/phui/object-item/phui-oi-list-view.css' => '9275ff55', 137 137 'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '6a30fa46', 138 138 'rsrc/css/phui/phui-action-list.css' => '1b0085b2', 139 139 'rsrc/css/phui/phui-action-panel.css' => '6c386cbf', ··· 182 182 'rsrc/css/phui/phui-two-column-view.css' => 'f96d319f', 183 183 'rsrc/css/phui/workboards/phui-workboard-color.css' => '3a1c21ff', 184 184 'rsrc/css/phui/workboards/phui-workboard.css' => '74fc9d98', 185 - 'rsrc/css/phui/workboards/phui-workcard.css' => '913441b6', 186 - 'rsrc/css/phui/workboards/phui-workpanel.css' => '3ae89b20', 185 + 'rsrc/css/phui/workboards/phui-workcard.css' => '62056e3b', 186 + 'rsrc/css/phui/workboards/phui-workpanel.css' => 'bc06f022', 187 187 'rsrc/css/sprite-login.css' => '35d1510c', 188 188 'rsrc/css/sprite-tokens.css' => 'f1896dc5', 189 189 'rsrc/css/syntax/syntax-default.css' => '055fc231', ··· 560 560 'conpherence-transaction-css' => '3a3f5e7e', 561 561 'd3' => '9d068042', 562 562 'diff-tree-view-css' => 'e2d3e222', 563 - 'differential-changeset-view-css' => 'bf159129', 563 + 'differential-changeset-view-css' => '8b9caefe', 564 564 'differential-core-view-css' => '7300a73e', 565 565 'differential-revision-add-comment-css' => '7e5900d9', 566 566 'differential-revision-comment-css' => '7dbc8d1d', ··· 579 579 'fuel-map-css' => 'd6e31510', 580 580 'fuel-menu-css' => '21f5d199', 581 581 'global-drag-and-drop-css' => '1d2713a4', 582 - 'harbormaster-css' => 'd98decda', 582 + 'harbormaster-css' => 'cd0ce059', 583 583 'herald-css' => '648d39e2', 584 584 'herald-rule-editor' => '2633bef7', 585 585 'herald-test-css' => '7e7bbdae', ··· 800 800 'phabricator-object-selector-css' => 'ee77366f', 801 801 'phabricator-phtize' => '2f1db1ed', 802 802 'phabricator-prefab' => '5793d835', 803 - 'phabricator-remarkup-css' => '5baa3bd9', 803 + 'phabricator-remarkup-css' => '3480e1fe', 804 804 'phabricator-remarkup-metadata' => 'e40c4991', 805 805 'phabricator-search-results-css' => '9ea70ace', 806 806 'phabricator-shaped-request' => '995f5102', 807 807 'phabricator-slowvote-css' => '1694baed', 808 - 'phabricator-source-code-view-css' => '6b31244f', 809 - 'phabricator-standard-page-view' => 'a374f94c', 808 + 'phabricator-source-code-view-css' => '49656486', 809 + 'phabricator-standard-page-view' => 'e08c7462', 810 810 'phabricator-textareautils' => 'f340a484', 811 811 'phabricator-title' => '43bc9360', 812 812 'phabricator-tooltip' => '83754533', ··· 829 829 'phui-box-css' => '5ed3b8cb', 830 830 'phui-bulk-editor-css' => '374d5e30', 831 831 'phui-button-bar-css' => 'a4aa75c4', 832 - 'phui-button-css' => 'e434f171', 832 + 'phui-button-css' => 'f9d0f9c8', 833 833 'phui-button-simple-css' => '1ff278aa', 834 834 'phui-calendar-css' => 'f11073aa', 835 835 'phui-calendar-day-css' => '9597d706', ··· 870 870 'phui-oi-color-css' => 'b517bfa0', 871 871 'phui-oi-drag-ui-css' => 'da15d3dc', 872 872 'phui-oi-flush-ui-css' => '490e2e2e', 873 - 'phui-oi-list-view-css' => 'af98a277', 873 + 'phui-oi-list-view-css' => '9275ff55', 874 874 'phui-oi-simple-ui-css' => '6a30fa46', 875 875 'phui-pager-css' => 'd022c7ad', 876 876 'phui-pinboard-view-css' => '1f08f5d8', ··· 886 886 'phui-two-column-view-css' => 'f96d319f', 887 887 'phui-workboard-color-css' => '3a1c21ff', 888 888 'phui-workboard-view-css' => '74fc9d98', 889 - 'phui-workcard-view-css' => '913441b6', 890 - 'phui-workpanel-view-css' => '3ae89b20', 889 + 'phui-workcard-view-css' => '62056e3b', 890 + 'phui-workpanel-view-css' => 'bc06f022', 891 891 'phuix-action-list-view' => 'c68f183f', 892 892 'phuix-action-view' => 'a8f573a9', 893 893 'phuix-autocomplete' => '2fbe234d', ··· 1246 1246 'trigger-rule-editor', 1247 1247 'trigger-rule', 1248 1248 'trigger-rule-type', 1249 - ), 1250 - '3ae89b20' => array( 1251 - 'phui-workcard-view-css', 1252 1249 ), 1253 1250 '3b4899b0' => array( 1254 1251 'javelin-behavior', ··· 1702 1699 'javelin-dom', 1703 1700 'phabricator-busy', 1704 1701 ), 1702 + '8b9caefe' => array( 1703 + 'phui-inline-comment-view-css', 1704 + ), 1705 1705 '8badee71' => array( 1706 1706 'javelin-install', 1707 1707 'javelin-util', ··· 2002 2002 'javelin-uri', 2003 2003 'phabricator-notification', 2004 2004 ), 2005 - 'bf159129' => array( 2006 - 'phui-inline-comment-view-css', 2005 + 'bc06f022' => array( 2006 + 'phui-workcard-view-css', 2007 2007 ), 2008 2008 'c03f2fb4' => array( 2009 2009 'javelin-install',
+1
src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php
··· 212 212 'line-height: 0.6rem;', 213 213 'border-radius: 3px;', 214 214 'box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08);', 215 + '-webkit-user-select: none;', 215 216 'user-select: none;', 216 217 'background: #f7f7f7;', 217 218 'border: 1px solid #C7CCD9;',
+1
webroot/rsrc/css/application/base/standard-page-view.css
··· 74 74 text-decoration: none; 75 75 border-radius: 3px; 76 76 box-shadow: inset 0 -1px 0 rgba({$alphablue}, 0.08); 77 + -webkit-user-select: none; 77 78 user-select: none; 78 79 color: {$darkgreytext}; 79 80 background: {$lightgreybackground};
-10
webroot/rsrc/css/application/differential/changeset-view.css
··· 432 432 433 433 .differential-diff.copy-l > tbody > tr > td, 434 434 .differential-diff.copy-r > tbody > tr > td { 435 - -moz-user-select: none; 436 - -ms-user-select: none; 437 435 -webkit-user-select: none; 438 436 user-select: none; 439 437 } 440 438 441 439 .differential-diff.copy-l > tbody > tr > td:nth-child(2) { 442 - -moz-user-select: auto; 443 - -ms-user-select: auto; 444 440 -webkit-user-select: auto; 445 441 user-select: auto; 446 442 } 447 443 448 444 .differential-diff.copy-l > tbody > tr > td.show-more:nth-child(2) { 449 - -moz-user-select: none; 450 - -ms-user-select: none; 451 445 -webkit-user-select: none; 452 446 user-select: none; 453 447 } 454 448 455 449 .differential-diff.copy-r > tbody > tr > td:nth-child(5) { 456 - -moz-user-select: auto; 457 - -ms-user-select: auto; 458 450 -webkit-user-select: auto; 459 451 user-select: auto; 460 452 } 461 453 462 454 .differential-diff.copy-l > tbody > tr.inline > td, 463 455 .differential-diff.copy-r > tbody > tr.inline > td { 464 - -moz-user-select: none; 465 - -ms-user-select: none; 466 456 -webkit-user-select: none; 467 457 user-select: none; 468 458 }
-3
webroot/rsrc/css/application/harbormaster/harbormaster.css
··· 44 44 background-color: {$paste.highlight}; 45 45 border-right: 1px solid {$paste.border}; 46 46 47 - -moz-user-select: -moz-none; 48 - -khtml-user-select: none; 49 47 -webkit-user-select: none; 50 - -ms-user-select: none; 51 48 user-select: none; 52 49 } 53 50
+1
webroot/rsrc/css/core/remarkup.css
··· 66 66 line-height: 0.6rem; 67 67 border-radius: 3px; 68 68 box-shadow: inset 0 -1px 0 rgba({$alphablue},0.08); 69 + -webkit-user-select: none; 69 70 user-select: none; 70 71 background: {$lightgreybackground}; 71 72 border: 1px solid {$lightgreyborder};
-3
webroot/rsrc/css/layout/phabricator-source-code-view.css
··· 76 76 77 77 .phabricator-source-blame-skip, 78 78 .phabricator-source-blame-info { 79 - -moz-user-select: -moz-none; 80 - -khtml-user-select: none; 81 79 -webkit-user-select: none; 82 - -ms-user-select: none; 83 80 user-select: none; 84 81 } 85 82
-2
webroot/rsrc/css/phui/button/phui-button.css
··· 9 9 font: {$basefont}; 10 10 -webkit-font-smoothing: antialiased; 11 11 -webkit-user-select: none; 12 - -moz-user-select: none; 13 - -ms-user-select: none; 14 12 user-select: none; 15 13 } 16 14
+1 -1
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
··· 675 675 676 676 .phui-oi-selectable { 677 677 cursor: pointer; 678 - user-select: none; 679 678 -webkit-user-select: none; 679 + user-select: none; 680 680 } 681 681 682 682 /* When the list selection state can be toggled on the client (as in the bulk
-3
webroot/rsrc/css/phui/workboards/phui-workcard.css
··· 28 28 .phui-workcard.phui-oi .phui-oi-objname { 29 29 -webkit-touch-callout: text; 30 30 -webkit-user-select: text; 31 - -khtml-user-select: text; 32 - -moz-user-select: text; 33 - -ms-user-select: text; 34 31 user-select: text; 35 32 } 36 33
-3
webroot/rsrc/css/phui/workboards/phui-workpanel.css
··· 29 29 .phui-workboard-view { 30 30 -webkit-touch-callout: none; 31 31 -webkit-user-select: none; 32 - -khtml-user-select: none; 33 - -moz-user-select: none; 34 - -ms-user-select: none; 35 32 user-select: none; 36 33 } 37 34