recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow object subtypes to be changed via bulk editor

Summary:
Ref T13151. See PHI683. Ref T12314.

You can currently change object subtypes via Conduit (`maniphest.edit`) but not via the web UI.

Changing object subtypes is inherently a somewhat-perilous operation that likely has a lot of rough edges we'll need to smooth over eventually, mostly around changing an object from subtype X to subtype Y, where some field exists on one but not the other. This isn't a huge issue, just not entirely intuitive.

It should also, in theory, be fairly rare.

As a reasonable middle ground, provide web UI access via the bulk editor. This makes it possible, but doesn't clutter the UI up with a rarely-used option with rough edges.

Test Plan:
- With subtypes not configured, saw a normal bulk editor with no new option.
- With subtypes configured, swapped tasks subtypes via bulk editor.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151, T12314

Differential Revision: https://secure.phabricator.com/D19490

epriestley c5b13a6b 62a40249

+5
+5
src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php
··· 47 47 ->setValue($object->getEditEngineSubtype()) 48 48 ->setOptions($options); 49 49 50 + // If subtypes are configured, enable changing them from the bulk editor. 51 + if (count($map) > 1) { 52 + $subtype_field->setBulkEditLabel(pht('Change subtype to')); 53 + } 54 + 50 55 return array( 51 56 $subtype_field, 52 57 );