recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow arc project and branch showing up in diff emails

Summary: Add the arc project and branch fields in emails for revisions under review. I am not quite sure why we only show them for changes which is already accepted or needs revision. It would be nice to have them for changes under review too.

Test Plan: Create a new revision and check email

Reviewers: epriestley, lifeihuang, JoelB, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8035

authored by

Peng Li and committed by
epriestley c5c9cd41 83ab275b

-14
-7
src/applications/differential/field/specification/DifferentialArcanistProjectFieldSpecification.php
··· 36 36 } 37 37 38 38 public function renderValueForMail($phase) { 39 - $status = $this->getRevision()->getStatus(); 40 - 41 - if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVISION && 42 - $status != ArcanistDifferentialRevisionStatus::ACCEPTED) { 43 - return null; 44 - } 45 - 46 39 $diff = $this->getRevision()->loadActiveDiff(); 47 40 if ($diff) { 48 41 $phid = $diff->getArcanistProjectPHID();
-7
src/applications/differential/field/specification/DifferentialBranchFieldSpecification.php
··· 32 32 } 33 33 34 34 public function renderValueForMail($phase) { 35 - $status = $this->getRevision()->getStatus(); 36 - 37 - if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVISION && 38 - $status != ArcanistDifferentialRevisionStatus::ACCEPTED) { 39 - return null; 40 - } 41 - 42 35 $diff = $this->getRevision()->loadActiveDiff(); 43 36 if ($diff) { 44 37 $description = $this->getBranchOrBookmarkDescription($diff);