@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Stop writes to the old Relationship table
Summary: Ref T1279. The new stuff seems stable, so stop writes to the old tables.
Test Plan:
- Added and removed reviewers.
- Grepped for `::RELATIONSHIP_TABLE` to verify we really have no more reads.
- Grepped for `::RELATION_REVIEWER`.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T1279
Differential Revision: https://secure.phabricator.com/D7360
-40
-40
src/applications/differential/editor/DifferentialRevisionEditor.php
-40
src/applications/differential/editor/DifferentialRevisionEditor.php
···
618
618
619
619
$reviewers = $revision->getReviewers();
620
620
621
-
// This is here until the new way proves stable enough
622
-
// See https://secure.phabricator.com/T1279
623
-
self::alterReviewers(
624
-
$revision,
625
-
$reviewers,
626
-
$remove_phids,
627
-
$add_phids,
628
-
$actor->getPHID());
629
-
630
621
$editor = id(new PhabricatorEdgeEditor())
631
622
->setActor($actor);
632
623
···
679
670
$reviewer_phid,
680
671
$status) {
681
672
682
-
$reviewers = $revision->getReviewers();
683
-
if (!in_array($reviewer_phid, $reviewers)) {
684
-
// This is here until the new way proves stable enough
685
-
// See https://secure.phabricator.com/T1279
686
-
self::alterReviewers(
687
-
$revision,
688
-
$reviewers,
689
-
array(),
690
-
array($reviewer_phid),
691
-
$actor->getPHID());
692
-
}
693
-
694
673
$options = array(
695
674
'data' => array(
696
675
'status' => $status
···
710
689
$reviewer_phid,
711
690
$options)
712
691
->save();
713
-
}
714
-
715
-
/**
716
-
* @deprecated
717
-
*/
718
-
private static function alterReviewers(
719
-
DifferentialRevision $revision,
720
-
array $stable_phids,
721
-
array $rem_phids,
722
-
array $add_phids,
723
-
$reason_phid) {
724
-
725
-
return self::alterRelationships(
726
-
$revision,
727
-
$stable_phids,
728
-
$rem_phids,
729
-
$add_phids,
730
-
$reason_phid,
731
-
DifferentialRevision::RELATION_REVIEWER);
732
692
}
733
693
734
694
private static function alterRelationships(