@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct line highlighting behavior in Diffusion
Summary: See <https://discourse.phabricator-community.org/t/line-highlighting-in-diffusion-breaks-url/1207>. Ref T13088. This was disrupted by changes for the new Harbormaster build logs and now needs an explicit base URI.
Test Plan: Clicked lines and dragged across line ranges in Diffusion, observed correct URI behavior.
Maniphest Tasks: T13088
Differential Revision: https://secure.phabricator.com/D19187
+13
-5
+13
-5
src/applications/diffusion/controller/DiffusionBrowseController.php
+13
-5
src/applications/diffusion/controller/DiffusionBrowseController.php
···
593
593
array(
594
594
'class' => 'diffusion-source remarkup-code PhabricatorMonospaced',
595
595
'sigil' => 'phabricator-source',
596
+
'meta' => array(
597
+
'uri' => $this->getLineNumberBaseURI(),
598
+
),
596
599
),
597
600
$rows);
598
601
···
1126
1129
1127
1130
// NOTE: We're doing this manually because rendering is otherwise
1128
1131
// dominated by URI generation for very large files.
1129
-
$line_base = (string)$drequest->generateURI(
1130
-
array(
1131
-
'action' => 'browse',
1132
-
'stable' => true,
1133
-
));
1132
+
$line_base = $this->getLineNumberBaseURI();
1134
1133
1135
1134
require_celerity_resource('aphront-tooltip-css');
1136
1135
Javelin::initBehavior('phabricator-oncopy');
···
2039
2038
->setTable($history_table);
2040
2039
}
2041
2040
2041
+
private function getLineNumberBaseURI() {
2042
+
$drequest = $this->getDiffusionRequest();
2043
+
2044
+
return (string)$drequest->generateURI(
2045
+
array(
2046
+
'action' => 'browse',
2047
+
'stable' => true,
2048
+
));
2049
+
}
2042
2050
}