@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make similar/subtask actions clickable

Summary: Adding better CSS and set correct tag and examples.

Test Plan: Test UIExamples, creating and click on similar task, empty task in Maniphest.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7423

Differential Revision: https://secure.phabricator.com/D11932

+19 -15
+3 -3
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => 'cb58febe', 10 + 'core.pkg.css' => 'cd54f10c', 11 11 'core.pkg.js' => '23d653bb', 12 12 'darkconsole.pkg.js' => '8ab24e01', 13 13 'differential.pkg.css' => '4c3242f8', ··· 135 135 'rsrc/css/phui/phui-icon.css' => 'd35aa857', 136 136 'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8', 137 137 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', 138 - 'rsrc/css/phui/phui-info-view.css' => '0c8e5d50', 138 + 'rsrc/css/phui/phui-info-view.css' => '6c6cc4dd', 139 139 'rsrc/css/phui/phui-list.css' => '53deb25c', 140 140 'rsrc/css/phui/phui-object-box.css' => 'd68ce5dc', 141 141 'rsrc/css/phui/phui-object-item-list-view.css' => '9db65899', ··· 789 789 'phui-icon-view-css' => 'd35aa857', 790 790 'phui-image-mask-css' => '5a8b09c8', 791 791 'phui-info-panel-css' => '27ea50a1', 792 - 'phui-info-view-css' => '0c8e5d50', 792 + 'phui-info-view-css' => '6c6cc4dd', 793 793 'phui-list-view-css' => '53deb25c', 794 794 'phui-object-box-css' => 'd68ce5dc', 795 795 'phui-object-item-list-view-css' => '9db65899',
+3
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 94 94 $info_view->setSeverity(PHUIInfoView::SEVERITY_NOTICE); 95 95 $info_view->addButton( 96 96 id(new PHUIButtonView()) 97 + ->setTag('a') 97 98 ->setHref('/maniphest/task/create/?parent='.$parent_task->getID()) 98 99 ->setText(pht('Create Another Subtask'))); 99 100 ··· 105 106 $info_view->setSeverity(PHUIInfoView::SEVERITY_NOTICE); 106 107 $info_view->addButton( 107 108 id(new PHUIButtonView()) 109 + ->setTag('a') 108 110 ->setHref('/maniphest/task/create/?template='.$task->getID()) 109 111 ->setText(pht('Similar Task'))); 110 112 $info_view->addButton( 111 113 id(new PHUIButtonView()) 114 + ->setTag('a') 112 115 ->setHref('/maniphest/task/create/') 113 116 ->setText(pht('Empty Task'))); 114 117 $info_view->appendChild(pht('New task created. Create another?'));
+1 -1
src/applications/uiexample/examples/PHUIInfoExample.php
··· 26 26 $button = id(new PHUIButtonView()) 27 27 ->setTag('a') 28 28 ->setText('Resolve Issue') 29 - ->addClass('grey'); 29 + ->setHref('#'); 30 30 31 31 $views = array(); 32 32 // Only Title
+2 -1
src/view/form/PHUIInfoView.php
··· 34 34 return $this; 35 35 } 36 36 37 - public function addButton($button) { 37 + public function addButton(PHUIButtonView $button) { 38 + 38 39 $this->buttons[] = $button; 39 40 return $this; 40 41 }
+10 -10
webroot/rsrc/css/phui/phui-info-view.css
··· 60 60 } 61 61 62 62 .phui-info-severity-error, 63 - .phui-info-severity-error .button { 63 + .phui-info-severity-error a.button { 64 64 border-color: {$red}; 65 65 background: {$lightred}; 66 66 } 67 67 68 - .phui-info-severity-error .button { 68 + .phui-info-severity-error a.button { 69 69 color: {$red}; 70 70 } 71 71 72 72 .phui-info-severity-warning, 73 - .phui-info-severity-warning .button { 73 + .phui-info-severity-warning a.button { 74 74 border-color: {$yellow}; 75 75 background: {$lightyellow}; 76 76 } 77 77 78 - .phui-info-severity-warning .button { 78 + .phui-info-severity-warning a.button { 79 79 color: #bc7837; 80 80 } 81 81 82 82 .phui-info-severity-notice, 83 - .phui-info-severity-notice .button { 83 + .phui-info-severity-notice a.button { 84 84 border-color: {$blue}; 85 85 background: {$lightblue}; 86 86 } 87 87 88 - .phui-info-severity-notice .button { 88 + .phui-info-severity-notice a.button { 89 89 color: {$blue}; 90 90 } 91 91 92 92 .phui-info-severity-nodata, 93 - .phui-info-severity-nodata .button { 93 + .phui-info-severity-nodata a.button { 94 94 border-color: {$lightgreyborder}; 95 95 background: #fff; 96 96 } 97 97 98 - .phui-info-severity-nodata .button { 98 + .phui-info-severity-nodata a.button { 99 99 color: {$greytext}; 100 100 } 101 101 102 102 .phui-info-severity-success, 103 - .phui-info-severity-success .button { 103 + .phui-info-severity-success a.button { 104 104 border-color: {$green}; 105 105 background: {$lightgreen}; 106 106 } 107 107 108 - .phui-info-severity-success .button { 108 + .phui-info-severity-success a.button { 109 109 color: {$green}; 110 110 } 111 111