@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Pholio feed fatal
Summary: need to filter images that we can't find mocks for. Fixes T3645. Note I have some other errors in my feed which are really tricky to debug and might be garbage data; I want to see what happens in prod post this push.
Test Plan: set a mock visibility to no one and feed worked
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T3645
Differential Revision: https://secure.phabricator.com/D6631
+8
-2
+8
-2
src/applications/pholio/query/PholioImageQuery.php
+8
-2
src/applications/pholio/query/PholioImageQuery.php
···
138
138
->execute();
139
139
$mocks = mpull($mocks, null, 'getID');
140
140
}
141
-
foreach ($images as $image) {
142
-
$image->attachMock($mocks[$image->getMockID()]);
141
+
foreach ($images as $index => $image) {
142
+
$mock = idx($mocks, $image->getMockID());
143
+
if ($mock) {
144
+
$image->attachMock($mock);
145
+
} else {
146
+
// mock is missing or we can't see it
147
+
unset($images[$index]);
148
+
}
143
149
}
144
150
145
151
return $images;