@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Cleanup Countdown manual construction of monograms/uris
Summary: looked for places where Countdown monograms/uris were being constructed by hand, and updated with modern versions
Test Plan: clicked around the Countdown UI, looking for broken links
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: chad, Korvin
Maniphest Tasks: T12524
Differential Revision: https://secure.phabricator.com/D17665
+7
-7
+1
-1
src/applications/countdown/controller/PhabricatorCountdownViewController.php
+1
-1
src/applications/countdown/controller/PhabricatorCountdownViewController.php
+3
-3
src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
+3
-3
src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
···
35
35
$name = $countdown->getTitle();
36
36
$id = $countdown->getID();
37
37
38
-
$handle->setName("C{$id}");
39
-
$handle->setFullName("C{$id}: {$name}");
40
-
$handle->setURI("/countdown/{$id}/");
38
+
$handle->setName($countdown->getMonogram());
39
+
$handle->setFullName(pht('%s: %s', $countdown->getMonogram(), $name));
40
+
$handle->setURI($countdown->getURI());
41
41
}
42
42
}
43
43
+1
-1
src/applications/countdown/query/PhabricatorCountdownSearchEngine.php
+1
-1
src/applications/countdown/query/PhabricatorCountdownSearchEngine.php
···
108
108
$item = id(new PHUIObjectItemView())
109
109
->setUser($viewer)
110
110
->setObject($countdown)
111
-
->setObjectName("C{$id}")
111
+
->setObjectName($countdown->getMonogram())
112
112
->setHeader($countdown->getTitle())
113
113
->setHref($this->getApplicationURI("{$id}/"))
114
114
->addByline(
+2
-2
src/applications/countdown/view/PhabricatorCountdownView.php
+2
-2
src/applications/countdown/view/PhabricatorCountdownView.php
···
14
14
require_celerity_resource('phabricator-countdown-css');
15
15
16
16
$header_text = array(
17
-
'C'.$countdown->getID(),
17
+
$countdown->getMonogram(),
18
18
' ',
19
19
phutil_tag(
20
20
'a',
21
21
array(
22
-
'href' => '/countdown/'.$countdown->getID(),
22
+
'href' => $countdown->getURI(),
23
23
),
24
24
$countdown->getTitle()),
25
25
);