recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Workboard: fix CTRL+click on "Create Task" and "Edit Task"

Summary:
The CTRL+click now opens the links in a new tab, like any other
normal link opened with CTRL+click.

Note that the middle-click was already working.

Closes T15157

Test Plan:
- visit a Workboard
- column > menu > mouse on "Create Task"
- CTRL+click: open in new tab (→ now works)
- normal click: open the pop-up (→ still works)
- middle-click: open in new tab (→ still works)
- column > single Task > mouse on "Edit"
- CTRL+click: open in new tab (→ now works)
- normal click: open the pop-up (→ still works)
- middle-click: open in new tab (→ still works)

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15157

Differential Revision: https://we.phorge.it/D25072

Valerio Bozzolan c6f56b82 b33e3735

+14
+14
webroot/rsrc/js/application/projects/WorkboardController.js
··· 151 151 }, 152 152 153 153 _onaddcard: function(e) { 154 + 155 + // Allow CTRL+click and maybe other actions 156 + if(!e.isNormalMouseEvent()) { 157 + e.stop(); 158 + return; 159 + } 160 + 154 161 // We want the 'boards-dropdown-menu' behavior to see this event and 155 162 // close the dropdown, but don't want to follow the link. 156 163 e.prevent(); ··· 176 183 }, 177 184 178 185 _oneditcard: function(e) { 186 + 187 + // Allow CTRL+click and maybe other actions 188 + if(!e.isNormalMouseEvent()) { 189 + e.stop(); 190 + return; 191 + } 192 + 179 193 e.kill(); 180 194 181 195 var column_node = e.getNode('project-column');