@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add missing `case` for personal ruls which create blocking reviewers
Summary: Ref T1279. I only tested the global case. :O
Test Plan: Created a personal "add me as blocking" rule.
Reviewers: btrahan, zeeg
Reviewed By: zeeg
CC: aran
Maniphest Tasks: T1279
Differential Revision: https://secure.phabricator.com/D7261
+1
-1
+1
-1
src/applications/herald/adapter/HeraldAdapter.php
+1
-1
src/applications/herald/adapter/HeraldAdapter.php
···
530
530
case self::ACTION_AUDIT:
531
531
case self::ACTION_ASSIGN_TASK:
532
532
case self::ACTION_ADD_REVIEWERS:
533
-
case self::ACTION_ADD_REVIEWERS:
533
+
case self::ACTION_ADD_BLOCKING_REVIEWERS:
534
534
// For personal rules, force these actions to target the rule owner.
535
535
$target = array($author_phid);
536
536
break;