@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix generation of "branch" URIs in Subversion repositories
Summary:
"Branch" really means "repository main screen, with some branch selected", so a branch isn't actually required since we can just take you to the default.
Fixes an issue where new crumbs would throw an exception in SVN repositories.
Test Plan: Browed an SVN repo.
Reviewers: btrahan, mbishopim3
Reviewed By: mbishopim3
CC: aran
Differential Revision: https://secure.phabricator.com/D7099
+5
-6
+5
-6
src/applications/diffusion/request/DiffusionRequest.php
+5
-6
src/applications/diffusion/request/DiffusionRequest.php
···
450
450
"Diffusion URI action '{$action}' requires callsign!");
451
451
}
452
452
453
-
if ($req_branch && !strlen($branch)) {
454
-
throw new Exception(
455
-
"Diffusion URI action '{$action}' requires branch!");
456
-
}
457
-
458
453
if ($req_commit && !strlen($commit)) {
459
454
throw new Exception(
460
455
"Diffusion URI action '{$action}' requires commit!");
···
471
466
$uri = "/diffusion/{$callsign}{$action}/{$path}{$commit}{$line}";
472
467
break;
473
468
case 'branch':
474
-
$uri = "/diffusion/{$callsign}repository/{$path}";
469
+
if (strlen($path)) {
470
+
$uri = "/diffusion/{$callsign}repository/{$path}";
471
+
} else {
472
+
$uri = "/diffusion/{$callsign}";
473
+
}
475
474
break;
476
475
case 'external':
477
476
$commit = ltrim($commit, ';');