@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow objects to be linked even if they are missing other fields
Summary: Fixes T5717. Like other partial edits, object links should not be blocked by unrelated missing fields on the object.
Test Plan:
- Linked two objects.
- Verified the inverse editor already sets "continue on missing fields" and "continue on no effect".
Reviewers: chad, btrahan, joshuaspence
Reviewed By: joshuaspence
Subscribers: epriestley
Maniphest Tasks: T5717
Differential Revision: https://secure.phabricator.com/D10059
+3
-1
+3
-1
src/applications/search/controller/PhabricatorSearchAttachController.php
+3
-1
src/applications/search/controller/PhabricatorSearchAttachController.php
···
106
106
107
107
$txn_editor = $object->getApplicationTransactionEditor()
108
108
->setActor($user)
109
-
->setContentSourceFromRequest($request);
109
+
->setContentSourceFromRequest($request)
110
+
->setContinueOnMissingFields(true);
111
+
110
112
$txn_template = $object->getApplicationTransactionTemplate()
111
113
->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
112
114
->setMetadataValue('edge:type', $edge_type)