recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correct rendering of workboard column move feed stories when a single transaction performs moves on multiple boards

Summary:
If a single transaction performs column moves on multiple different boards (which is permitted in the API), the rendering logic in the feed currently fails. Make it render properly.

Same fix as rPa3f4cbd7484b591425e83bbfc7642bccb04d0d57 for `getTitle()` which left out also fixing `getTitleForFeed()`.

Test Plan: Carefully read the if/else logic.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25646

Andre Klapper c769125e 290f3d63

+2
+2
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
··· 1475 1475 } else { 1476 1476 $fragments = array(); 1477 1477 foreach ($moves as $move) { 1478 + $to_column = $move['columnPHID']; 1479 + $board_phid = $move['boardPHID']; 1478 1480 $fragments[] = pht( 1479 1481 '%s (%s)', 1480 1482 $this->renderHandleLink($board_phid),