recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add some missing rendering code to textual feed stories

Summary: Ref T2852. Token given stories currently try to `strip_tags()` a `PHUIFeedView` or similar, which doesn't work. Cast it to a string before stripping. This is super gross but I don't want to clean it up until after ApplicationTransactions so we can really clean up all of Feed.

Test Plan: Ran `bin/feed republish <id>` on a feed story about giving a token to a revision.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6733

epriestley c7a84876 f11a4d5e

+2 -2
+1 -1
src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php
··· 35 35 36 36 public function renderText() { 37 37 // TODO: This is grotesque; the feed notification handler relies on it. 38 - return strip_tags($this->renderView()->render()); 38 + return strip_tags(hsprintf('%s', $this->renderView()->render())); 39 39 } 40 40 41 41 }
+1 -1
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
··· 57 57 58 58 public function renderText() { 59 59 // TODO: This is grotesque; the feed notification handler relies on it. 60 - return strip_tags($this->renderView()->render()); 60 + return strip_tags(hsprintf('%s', $this->renderView()->render())); 61 61 } 62 62 63 63 }