recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Spaces - re-jigger application name for new Spaces application

Summary: got some errors in my sandbox when I updated. this fixes them and I think is the right naming convention.

Test Plan: /settings/panel/emailpreferences/ started working again! /spaces/ also loaded unit tests passed without errors

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8377

Differential Revision: https://secure.phabricator.com/D13103

Bob Trahan c83ddc3a 76523eec

+5 -5
+2 -2
src/__phutil_library_map__.php
··· 1318 1318 'PhabricatorApplicationSearchController' => 'applications/search/controller/PhabricatorApplicationSearchController.php', 1319 1319 'PhabricatorApplicationSearchEngine' => 'applications/search/engine/PhabricatorApplicationSearchEngine.php', 1320 1320 'PhabricatorApplicationSearchResultsControllerInterface' => 'applications/search/interface/PhabricatorApplicationSearchResultsControllerInterface.php', 1321 - 'PhabricatorApplicationSpaces' => 'applications/spaces/application/PhabricatorApplicationSpaces.php', 1322 1321 'PhabricatorApplicationStatusView' => 'applications/meta/view/PhabricatorApplicationStatusView.php', 1323 1322 'PhabricatorApplicationTransaction' => 'applications/transactions/storage/PhabricatorApplicationTransaction.php', 1324 1323 'PhabricatorApplicationTransactionComment' => 'applications/transactions/storage/PhabricatorApplicationTransactionComment.php', ··· 2562 2561 'PhabricatorSlugTestCase' => 'infrastructure/util/__tests__/PhabricatorSlugTestCase.php', 2563 2562 'PhabricatorSortTableUIExample' => 'applications/uiexample/examples/PhabricatorSortTableUIExample.php', 2564 2563 'PhabricatorSourceCodeView' => 'view/layout/PhabricatorSourceCodeView.php', 2564 + 'PhabricatorSpacesApplication' => 'applications/spaces/application/PhabricatorSpacesApplication.php', 2565 2565 'PhabricatorSpacesCapabilityCreateSpaces' => 'applications/spaces/capability/PhabricatorSpacesCapabilityCreateSpaces.php', 2566 2566 'PhabricatorSpacesCapabilityDefaultEdit' => 'applications/spaces/capability/PhabricatorSpacesCapabilityDefaultEdit.php', 2567 2567 'PhabricatorSpacesCapabilityDefaultView' => 'applications/spaces/capability/PhabricatorSpacesCapabilityDefaultView.php', ··· 4665 4665 'PhabricatorApplicationPanelController' => 'PhabricatorApplicationsController', 4666 4666 'PhabricatorApplicationQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 4667 4667 'PhabricatorApplicationSearchController' => 'PhabricatorSearchBaseController', 4668 - 'PhabricatorApplicationSpaces' => 'PhabricatorApplication', 4669 4668 'PhabricatorApplicationStatusView' => 'AphrontView', 4670 4669 'PhabricatorApplicationTransaction' => array( 4671 4670 'PhabricatorLiskDAO', ··· 6046 6045 'PhabricatorSlugTestCase' => 'PhabricatorTestCase', 6047 6046 'PhabricatorSortTableUIExample' => 'PhabricatorUIExample', 6048 6047 'PhabricatorSourceCodeView' => 'AphrontView', 6048 + 'PhabricatorSpacesApplication' => 'PhabricatorApplication', 6049 6049 'PhabricatorSpacesCapabilityCreateSpaces' => 'PhabricatorPolicyCapability', 6050 6050 'PhabricatorSpacesCapabilityDefaultEdit' => 'PhabricatorPolicyCapability', 6051 6051 'PhabricatorSpacesCapabilityDefaultView' => 'PhabricatorPolicyCapability',
+1 -1
src/applications/spaces/application/PhabricatorApplicationSpaces.php src/applications/spaces/application/PhabricatorSpacesApplication.php
··· 1 1 <?php 2 2 3 - final class PhabricatorApplicationSpaces extends PhabricatorApplication { 3 + final class PhabricatorSpacesApplication extends PhabricatorApplication { 4 4 5 5 public function getBaseURI() { 6 6 return '/spaces/';
+1 -1
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
··· 23 23 } 24 24 25 25 public function getQueryApplicationClass() { 26 - return 'PhabricatorApplicationSpaces'; 26 + return 'PhabricatorSpacesApplication'; 27 27 } 28 28 29 29 protected function loadPage() {
+1 -1
src/applications/spaces/storage/PhabricatorSpacesNamespace.php
··· 15 15 public static function initializeNewNamespace(PhabricatorUser $actor) { 16 16 $app = id(new PhabricatorApplicationQuery()) 17 17 ->setViewer($actor) 18 - ->withClasses(array('PhabricatorApplicationSpaces')) 18 + ->withClasses(array('PhabricatorSpacesApplication')) 19 19 ->executeOne(); 20 20 21 21 $view_policy = $app->getPolicy(