recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15374

Test Plan: Applied these two changes, performed the user creation steps again, and afterwards the user page at `/p/user5/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15374

Differential Revision: https://we.phorge.it/D25208

Andre Klapper c86364c2 ac4c9516

+2 -2
+2 -2
src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php
··· 118 118 $recipient = $this->getRecipient(); 119 119 120 120 $custom_body = $this->getWelcomeMessage(); 121 - if (strlen($custom_body)) { 121 + if (phutil_nonempty_string($custom_body)) { 122 122 return $this->newRemarkupText($custom_body); 123 123 } 124 124 125 125 $default_body = PhabricatorAuthMessage::loadMessageText( 126 126 $recipient, 127 127 PhabricatorAuthWelcomeMailMessageType::MESSAGEKEY); 128 - if (strlen($default_body)) { 128 + if (phutil_nonempty_string($default_body)) { 129 129 return $this->newRemarkupText($default_body); 130 130 } 131 131