@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Mark sessions as "signed all documents" when Legalpad has been uninstalled
See PHI238. When an install uninstalls "Legalpad", we were incorrectly failing
to mark sessions as "Signed All Required Documents" by bailing early.
Test Plan: Uninstalled Legalpad, logged in.
+14
-14
+14
-14
src/applications/base/controller/PhabricatorController.php
+14
-14
src/applications/base/controller/PhabricatorController.php
···
562
562
return null;
563
563
}
564
564
565
+
$must_sign_docs = array();
566
+
$sign_docs = array();
567
+
565
568
$legalpad_class = 'PhabricatorLegalpadApplication';
566
569
$legalpad_installed = PhabricatorApplication::isClassInstalledForViewer(
567
570
$legalpad_class,
568
571
$viewer);
569
-
if (!$legalpad_installed) {
570
-
return null;
571
-
}
572
-
573
-
$sign_docs = id(new LegalpadDocumentQuery())
574
-
->setViewer($viewer)
575
-
->withSignatureRequired(1)
576
-
->needViewerSignatures(true)
577
-
->setOrder('oldest')
578
-
->execute();
572
+
if ($legalpad_installed) {
573
+
$sign_docs = id(new LegalpadDocumentQuery())
574
+
->setViewer($viewer)
575
+
->withSignatureRequired(1)
576
+
->needViewerSignatures(true)
577
+
->setOrder('oldest')
578
+
->execute();
579
579
580
-
$must_sign_docs = array();
581
-
foreach ($sign_docs as $sign_doc) {
582
-
if (!$sign_doc->getUserSignature($viewer->getPHID())) {
583
-
$must_sign_docs[] = $sign_doc;
580
+
foreach ($sign_docs as $sign_doc) {
581
+
if (!$sign_doc->getUserSignature($viewer->getPHID())) {
582
+
$must_sign_docs[] = $sign_doc;
583
+
}
584
584
}
585
585
}
586
586