@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "behindTransactionPHID" from ConpherenceParticipant
Summary: Pathway to D17685. Nothing reads this field and it has no use or value.
Test Plan:
- Ran migration.
- Grepped for `behindTransactionPHID`.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D17729
+3
-8
+2
resources/sql/autopatches/20170419.thread.01.behind.sql
+2
resources/sql/autopatches/20170419.thread.01.behind.sql
+1
-6
src/applications/conpherence/editor/ConpherenceEditor.php
+1
-6
src/applications/conpherence/editor/ConpherenceEditor.php
···
168
168
// participation data asap to pass policy checks. For existing
169
169
// ConpherenceThreads, the existing participation is correct
170
170
// at this stage. Note that later in applyCustomExternalTransaction
171
-
// this participation data will be updated, particularly the
172
-
// behindTransactionPHID which is just a generated dummy for now.
171
+
// this participation data will be updated.
173
172
$participants = array();
174
173
$phids = $this->getPHIDTransactionNewValue($xaction, array());
175
174
foreach ($phids as $phid) {
···
186
185
->setParticipantPHID($phid)
187
186
->setParticipationStatus($status)
188
187
->setDateTouched(time())
189
-
->setBehindTransactionPHID($xaction->generatePHID())
190
188
->setSeenMessageCount($message_count)
191
189
->save();
192
190
$object->attachParticipants($participants);
···
257
255
->setParticipantPHID($phid)
258
256
->setParticipationStatus($status)
259
257
->setDateTouched(time())
260
-
->setBehindTransactionPHID($xaction->getPHID())
261
258
->setSeenMessageCount($message_count)
262
259
->save();
263
260
}
···
290
287
foreach ($participants as $phid => $participant) {
291
288
if ($phid != $user->getPHID()) {
292
289
if ($participant->getParticipationStatus() != $behind) {
293
-
$participant->setBehindTransactionPHID($xaction_phid);
294
290
$participant->setSeenMessageCount(
295
291
$object->getMessageCount() - $message_count);
296
292
}
···
298
294
$participant->setDateTouched($time);
299
295
} else {
300
296
$participant->setSeenMessageCount($object->getMessageCount());
301
-
$participant->setBehindTransactionPHID($xaction_phid);
302
297
$participant->setParticipationStatus($up_to_date);
303
298
$participant->setDateTouched($time);
304
299
}
-2
src/applications/conpherence/storage/ConpherenceParticipant.php
-2
src/applications/conpherence/storage/ConpherenceParticipant.php
···
5
5
protected $participantPHID;
6
6
protected $conpherencePHID;
7
7
protected $participationStatus;
8
-
protected $behindTransactionPHID;
9
8
protected $seenMessageCount;
10
9
protected $dateTouched;
11
10
protected $settings = array();
···
44
43
ConpherenceTransaction $xaction) {
45
44
if (!$this->isUpToDate($conpherence)) {
46
45
$this->setParticipationStatus(ConpherenceParticipationStatus::UP_TO_DATE);
47
-
$this->setBehindTransactionPHID($xaction->getPHID());
48
46
$this->setSeenMessageCount($conpherence->getMessageCount());
49
47
$this->save();
50
48