@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't show tag when no topic is set
Summary: Check the strlen of topic before adding a tag to the header in Conpherence.
Test Plan: Remove a topic, no longer see indigo bubble.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17715
+9
-6
+9
-6
src/applications/conpherence/controller/ConpherenceController.php
+9
-6
src/applications/conpherence/controller/ConpherenceController.php
···
60
60
61
61
if ($conpherence->getID()) {
62
62
$data = $conpherence->getDisplayData($this->getViewer());
63
-
$topic = id(new PHUITagView())
64
-
->setName($data['topic'])
65
-
->setShade(PHUITagView::COLOR_VIOLET)
66
-
->setType(PHUITagView::TYPE_SHADE)
67
-
->addClass('conpherence-header-topic');
68
63
69
64
$header = id(new PHUIHeaderView())
70
65
->setViewer($viewer)
71
66
->setHeader($data['title'])
72
-
->addTag($topic)
73
67
->setPolicyObject($conpherence)
74
68
->setImage($data['image']);
69
+
70
+
if (strlen($data['topic'])) {
71
+
$topic = id(new PHUITagView())
72
+
->setName($data['topic'])
73
+
->setShade(PHUITagView::COLOR_VIOLET)
74
+
->setType(PHUITagView::TYPE_SHADE)
75
+
->addClass('conpherence-header-topic');
76
+
$header->addTag($topic);
77
+
}
75
78
76
79
$can_edit = PhabricatorPolicyFilter::hasCapability(
77
80
$viewer,